Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36484 )
Change subject: vendorcode/eltan/security: corrected debug output ......................................................................
vendorcode/eltan/security: corrected debug output
Corrected debug ouput in tpm2_get_capability_pcrs.
BUG=N/A TEST=build
Change-Id: Ibd12c9dc22980f21ecba204729c5da0d11618e12 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/vendorcode/eltan/security/mboot/mboot.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/36484/1
diff --git a/src/vendorcode/eltan/security/mboot/mboot.c b/src/vendorcode/eltan/security/mboot/mboot.c index 3799b8a..2f33a3d 100644 --- a/src/vendorcode/eltan/security/mboot/mboot.c +++ b/src/vendorcode/eltan/security/mboot/mboot.c @@ -102,8 +102,8 @@ for (index = 0; index < Pcrs->count; index++) { Pcrs->pcrSelections[index].hash = swab16(TpmCap.data.assignedPCR.pcrSelections[index].hash); - printk(BIOS_DEBUG, "Pcrs->pcrSelections[index].hash =" - "0x%x\n", Pcrs->pcrSelections[index].hash); + printk(BIOS_DEBUG, "Pcrs->pcrSelections[%d].hash = 0x%x\n", index, + Pcrs->pcrSelections[index].hash); Pcrs->pcrSelections[index].sizeofSelect = TpmCap.data.assignedPCR.pcrSelections[index].sizeofSelect; memcpy(Pcrs->pcrSelections[index].pcrSelect,
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36484 )
Change subject: vendorcode/eltan/security: corrected debug output ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36484 )
Change subject: vendorcode/eltan/security: corrected debug output ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36484/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36484/2//COMMIT_MSG@7 PS2, Line 7: corrected Correct
Hello Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36484
to look at the new patch set (#3).
Change subject: vendorcode/eltan/security: Correct debug output ......................................................................
vendorcode/eltan/security: Correct debug output
Corrected debug ouput in tpm2_get_capability_pcrs.
BUG=N/A TEST=build
Change-Id: Ibd12c9dc22980f21ecba204729c5da0d11618e12 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/vendorcode/eltan/security/mboot/mboot.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/36484/3
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36484 )
Change subject: vendorcode/eltan/security: Correct debug output ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36484/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36484/2//COMMIT_MSG@7 PS2, Line 7: corrected
Correct
Done
Hello Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36484
to look at the new patch set (#4).
Change subject: vendorcode/eltan/security: Correct debug output ......................................................................
vendorcode/eltan/security: Correct debug output
Correct debug ouput in tpm2_get_capability_pcrs.
BUG=N/A TEST=build
Change-Id: Ibd12c9dc22980f21ecba204729c5da0d11618e12 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/vendorcode/eltan/security/mboot/mboot.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/36484/4
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36484 )
Change subject: vendorcode/eltan/security: Correct debug output ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36484 )
Change subject: vendorcode/eltan/security: Correct debug output ......................................................................
vendorcode/eltan/security: Correct debug output
Correct debug ouput in tpm2_get_capability_pcrs.
BUG=N/A TEST=build
Change-Id: Ibd12c9dc22980f21ecba204729c5da0d11618e12 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36484 Reviewed-by: Frans Hendriks fhendriks@eltan.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/vendorcode/eltan/security/mboot/mboot.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved
diff --git a/src/vendorcode/eltan/security/mboot/mboot.c b/src/vendorcode/eltan/security/mboot/mboot.c index 1e1bc29..b24bf3d 100644 --- a/src/vendorcode/eltan/security/mboot/mboot.c +++ b/src/vendorcode/eltan/security/mboot/mboot.c @@ -102,8 +102,8 @@ for (index = 0; index < Pcrs->count; index++) { Pcrs->pcrSelections[index].hash = swab16(TpmCap.data.assignedPCR.pcrSelections[index].hash); - printk(BIOS_DEBUG, "Pcrs->pcrSelections[index].hash =" - "0x%x\n", Pcrs->pcrSelections[index].hash); + printk(BIOS_DEBUG, "Pcrs->pcrSelections[%d].hash = 0x%x\n", index, + Pcrs->pcrSelections[index].hash); Pcrs->pcrSelections[index].sizeofSelect = TpmCap.data.assignedPCR.pcrSelections[index].sizeofSelect; memcpy(Pcrs->pcrSelections[index].pcrSelect,