Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30103 )
Change subject: src/cpu/intel: Set get_ia32_fsb function common
......................................................................
Patch Set 22:
(2 comments)
https://review.coreboot.org/#/c/30103/22/src/cpu/x86/lapic/apic_timer.c
File src/cpu/x86/lapic/apic_timer.c:
https://review.coreboot.org/#/c/30103/22/src/cpu/x86/lapic/apic_timer.c@50
PS22, Line 50: != -1
should be `>= 0` now (or `> 0`)
https://review.coreboot.org/#/c/30103/22/src/include/cpu/intel/fsb.h
File src/include/cpu/intel/fsb.h:
https://review.coreboot.org/#/c/30103/22/src/include/cpu/intel/fsb.h@23
PS22, Line 23:
spurious empty line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30103
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I232bf88de7ebba6ac5865db046ce79e9b2f3ed28
Gerrit-Change-Number: 30103
Gerrit-PatchSet: 22
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 11 Jan 2019 15:45:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment