Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35470 )
Change subject: mb/google/hatch: Add G2Touch Touchscreen support ......................................................................
mb/google/hatch: Add G2Touch Touchscreen support
Add G2Touch Touchscreen support for dratini
BUG=b:141281841 TEST=emerge-hatch coreboot chromeos-bootimage, and check touchscreen work.
Change-Id: I0dbde7f8396da6335b22aeb4a9703336e2b862b8 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/hatch/variants/dratini/overridetree.cb 1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/35470/1
diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb index b2ec3d7..65649d1 100644 --- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb @@ -65,6 +65,20 @@ end end # I2C #0 device pci 15.1 on + chip drivers/i2c/hid + register "generic.hid" = ""GTCH7503"" + register "generic.desc" = ""G2TOUCH Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "generic.reset_delay_ms" = "50" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)" + register "generic.enable_delay_ms" = "1" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 40 on end + end chip drivers/i2c/generic register "hid" = ""ELAN0001"" register "desc" = ""ELAN Touchscreen""
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35470 )
Change subject: mb/google/hatch: Add G2Touch Touchscreen support ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35470/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35470/1/src/mainboard/google/hatch/... PS1, Line 69: GTCH7503 I'm sure this is fine, b/c I see that Bloog used it too, but which kernel driver does this bind to? I don't see this ACPI ID used anywhere in 4.19.
https://review.coreboot.org/c/coreboot/+/35470/1/src/mainboard/google/hatch/... PS1, Line 73: ACPI_GPIO_OUTPUT_ACTIVE_LOW All of the other boards that use this touchscreen have the reset GPIO marked as active-high, and I can't find the datasheet for this part. Is this a different part that has an active-low reset?
Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35470 )
Change subject: mb/google/hatch: Add G2Touch Touchscreen support ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35470/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35470/1/src/mainboard/google/hatch/... PS1, Line 69: GTCH7503
I'm sure this is fine, b/c I see that Bloog used it too, but which kernel driver does this bind to? […]
In my understanding, it use common hid-i2c driver, it will not bind specific kernel driver.
https://review.coreboot.org/c/coreboot/+/35470/1/src/mainboard/google/hatch/... PS1, Line 73: ACPI_GPIO_OUTPUT_ACTIVE_LOW
All of the other boards that use this touchscreen have the reset GPIO marked as active-high, and I c […]
I think it's the same. It passed through level reverse in octopus. In hatch, it passed through level shift.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35470 )
Change subject: mb/google/hatch: Add G2Touch Touchscreen support ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35470/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35470/1/src/mainboard/google/hatch/... PS1, Line 69: GTCH7503
In my understanding, it use common hid-i2c driver, it will not bind specific kernel driver.
That's right. It uses the i2c-hid driver based on this: https://review.coreboot.org/cgit/coreboot.git/tree/src/drivers/i2c/hid/hid.c...
https://chromium.googlesource.com/chromiumos/third_party/kernel/+/refs/heads...
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35470 )
Change subject: mb/google/hatch: Add G2Touch Touchscreen support ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/35470/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35470/1/src/mainboard/google/hatch/... PS1, Line 69: GTCH7503
That's right. It uses the i2c-hid driver based on this: https://review.coreboot.org/cgit/coreboot. […]
Ack
https://review.coreboot.org/c/coreboot/+/35470/1/src/mainboard/google/hatch/... PS1, Line 73: ACPI_GPIO_OUTPUT_ACTIVE_LOW
I think it's the same. It passed through level reverse in octopus. […]
Ack
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35470 )
Change subject: mb/google/hatch: Add G2Touch Touchscreen support ......................................................................
mb/google/hatch: Add G2Touch Touchscreen support
Add G2Touch Touchscreen support for dratini
BUG=b:141281841 TEST=emerge-hatch coreboot chromeos-bootimage, and check touchscreen work.
Change-Id: I0dbde7f8396da6335b22aeb4a9703336e2b862b8 Signed-off-by: Wisley Chen wisley.chen@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35470 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/dratini/overridetree.cb 1 file changed, 14 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb index b2ec3d7..65649d1 100644 --- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb @@ -65,6 +65,20 @@ end end # I2C #0 device pci 15.1 on + chip drivers/i2c/hid + register "generic.hid" = ""GTCH7503"" + register "generic.desc" = ""G2TOUCH Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "generic.reset_delay_ms" = "50" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)" + register "generic.enable_delay_ms" = "1" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 40 on end + end chip drivers/i2c/generic register "hid" = ""ELAN0001"" register "desc" = ""ELAN Touchscreen""
-
Chen Wisley (Code Review) -
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)
-
Tim Wawrzynczak (Code Review)