Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40415 )
Change subject: mb/google/puff: add a region to cache SPD data ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40415/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/romstage_spd_smbus.c:
https://review.coreboot.org/c/coreboot/+/40415/4/src/mainboard/google/hatch/... PS4, Line 40: get_spd_sn(blk.addr_map[i], SPD_DRAM_DDR4, sn);
my 2 cents […]
Done
https://review.coreboot.org/c/coreboot/+/40415/4/src/mainboard/google/hatch/... PS4, Line 46: DDR4_SPD_SN_OFF
can you make it to DDR4_SPD_SN_OFFSET?
I think keep the DDR4_SPD_SN_OFF is better because there is the same naming style in spd_bin.h
https://review.coreboot.org/c/coreboot/+/40415/4/src/mainboard/google/hatch/... PS4, Line 85: (uintptr_t)blk.spd_array[0];
i guess you can add few more tabs to get closer to the `=` in previous line
Done
https://review.coreboot.org/c/coreboot/+/40415/4/src/mainboard/google/hatch/... PS4, Line 96: (uintptr_t)blk.spd_array[1];
i guess you can add few more tabs to get closer to the `=` in previous line
Done