4 comments:
File src/mainboard/google/hatch/romstage_spd_smbus.c:
Patch Set #4, Line 40: get_spd_sn(blk.addr_map[i], SPD_DRAM_DDR4, sn);
my 2 cents […]
Done
Patch Set #4, Line 46: DDR4_SPD_SN_OFF
can you make it to DDR4_SPD_SN_OFFSET?
I think keep the DDR4_SPD_SN_OFF is better because there is the same naming style in spd_bin.h
Patch Set #4, Line 85: (uintptr_t)blk.spd_array[0];
i guess you can add few more tabs to get closer to the `=` in previous line
Done
Patch Set #4, Line 96: (uintptr_t)blk.spd_array[1];
i guess you can add few more tabs to get closer to the `=` in previous line
Done
To view, visit change 40415. To unsubscribe, or for help writing mail filters, visit settings.