Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40415 )
Change subject: mb/google/puff: add a region to cache SPD data ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40415/5/src/mainboard/google/hatch/... File src/mainboard/google/hatch/romstage_spd_smbus.c:
https://review.coreboot.org/c/coreboot/+/40415/5/src/mainboard/google/hatch/... PS5, Line 28: SPD_CACHE
You can remove the underline here. […]
Done
https://review.coreboot.org/c/coreboot/+/40415/5/src/mainboard/google/hatch/... PS5, Line 47: if (need_update_cache)
oh, one false case is load_spd_cache error.
We don't need to update SPD cache when we cannot load SPD cache successfully. If there is a project without RW_SPD_CACHE region, it will keep the original flow here.
https://review.coreboot.org/c/coreboot/+/40415/5/src/mainboard/google/hatch/... PS5, Line 47: if (need_update_cache)
If dimm_changed, we need update cache anyway, right? Any condition will be dimm_changed but doesn't […]
We don't need to update SPD cache when we cannot load SPD cache successfully. If there is a project without RW_SPD_CACHE region, it will keep the original flow here.