Attention is currently required from: Arthur Heymans, Benjamin Doron, Christian Walter, Himanshu Sahdev, Julius Werner, Maximilian Brune, Michał Kopeć, Michał Żygowski, Sergii Dmytruk.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68749?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: util/cbmem: add parsing of TPM logs per standard
......................................................................
Patch Set 19: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68749/comment/e91d2334_5b268108 :
PS19, Line 9: coreboot is made to export the range allocated for the log.
Sorry, I do not understand this sentence. This patch only changes the cbmem utility, doesn’t it?
https://review.coreboot.org/c/coreboot/+/68749/comment/44d5c403_ff49b1fa :
PS19, Line 12:
1. Could you please give some more background on the implementation. You check CBMEM for certain fields (`CBMEM_ID_TCPA_TCG_LOG`)?
2. Pleases add a TEST= line with the output printed by the new code.
Patchset:
PS19:
Thank you for your work. If my comments don’t make any sense, feel free to mark them resolved.
File util/cbmem/cbmem.c:
https://review.coreboot.org/c/coreboot/+/68749/comment/7e12af64_2dbd02bf :
PS19, Line 899: printf("\tEvent type: Unknown (0x%x)\n", event_type);
`ARRAY_SIZE(tpm_event_types)` could also be printed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68749?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib76dc7dec56dd1789a219539a1ac05a958f47a5c
Gerrit-Change-Number: 68749
Gerrit-PatchSet: 19
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Sat, 17 Jun 2023 07:12:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment