HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34230 )
Change subject: src: Remove unneeded 'include <delay.h>' ......................................................................
src: Remove unneeded 'include <delay.h>'
Change-Id: Ibf91c35aa389a91116463616a778212bb386756e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/ipmi/ipmi_kcs_ops.c M src/mainboard/getac/p470/mainboard.c M src/soc/mediatek/common/rtc.c M src/soc/qualcomm/qcs405/clock.c M src/soc/qualcomm/qcs405/gpio.c M src/soc/qualcomm/qcs405/i2c.c M src/soc/qualcomm/sdm845/usb.c 7 files changed, 1 insertion(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/34230/1
diff --git a/src/drivers/ipmi/ipmi_kcs_ops.c b/src/drivers/ipmi/ipmi_kcs_ops.c index 0cc4e0a..8e02b28 100644 --- a/src/drivers/ipmi/ipmi_kcs_ops.c +++ b/src/drivers/ipmi/ipmi_kcs_ops.c @@ -31,7 +31,7 @@ #include <smbios.h> #endif #include <version.h> -#include <delay.h> + #include "ipmi_kcs.h" #include "chip.h"
diff --git a/src/mainboard/getac/p470/mainboard.c b/src/mainboard/getac/p470/mainboard.c index 813b1d6..da90349 100644 --- a/src/mainboard/getac/p470/mainboard.c +++ b/src/mainboard/getac/p470/mainboard.c @@ -17,7 +17,6 @@ #include <device/device.h> #include <device/pci_def.h> #include <device/pci_ops.h> -#include <delay.h> #include <drivers/intel/gma/int15.h>
diff --git a/src/soc/mediatek/common/rtc.c b/src/soc/mediatek/common/rtc.c index fe252b5..080f334 100644 --- a/src/soc/mediatek/common/rtc.c +++ b/src/soc/mediatek/common/rtc.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <delay.h> #include <soc/rtc_common.h> #include <soc/rtc.h> #include <soc/pmic_wrap.h> diff --git a/src/soc/qualcomm/qcs405/clock.c b/src/soc/qualcomm/qcs405/clock.c index 56824a4..8a17e37 100644 --- a/src/soc/qualcomm/qcs405/clock.c +++ b/src/soc/qualcomm/qcs405/clock.c @@ -14,8 +14,6 @@
#include <console/console.h> #include <device/mmio.h> -#include <types.h> -#include <delay.h> #include <timestamp.h> #include <commonlib/helpers.h> #include <string.h> diff --git a/src/soc/qualcomm/qcs405/gpio.c b/src/soc/qualcomm/qcs405/gpio.c index 7b2238d..1d18250 100644 --- a/src/soc/qualcomm/qcs405/gpio.c +++ b/src/soc/qualcomm/qcs405/gpio.c @@ -15,7 +15,6 @@
#include <device/mmio.h> #include <types.h> -#include <delay.h> #include <timestamp.h> #include <gpio.h>
diff --git a/src/soc/qualcomm/qcs405/i2c.c b/src/soc/qualcomm/qcs405/i2c.c index 94f8e0d..77c381c 100644 --- a/src/soc/qualcomm/qcs405/i2c.c +++ b/src/soc/qualcomm/qcs405/i2c.c @@ -31,7 +31,6 @@
#include <assert.h> #include <console/console.h> -#include <delay.h> #include <device/i2c_simple.h> #include <stdlib.h> #include <string.h> diff --git a/src/soc/qualcomm/sdm845/usb.c b/src/soc/qualcomm/sdm845/usb.c index c7d65e6..062cd94 100644 --- a/src/soc/qualcomm/sdm845/usb.c +++ b/src/soc/qualcomm/sdm845/usb.c @@ -17,7 +17,6 @@ #include <lib.h> #include <stdlib.h> #include <console/console.h> -#include <delay.h> #include <soc/usb.h> #include <soc/clock.h> #include <soc/addressmap.h>
Hello Julius Werner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34230
to look at the new patch set (#2).
Change subject: src: Remove unneeded 'include <delay.h>' ......................................................................
src: Remove unneeded 'include <delay.h>'
Change-Id: Ibf91c35aa389a91116463616a778212bb386756e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/ipmi/ipmi_kcs_ops.c M src/mainboard/getac/p470/mainboard.c M src/soc/mediatek/common/rtc.c M src/soc/qualcomm/qcs405/clock.c M src/soc/qualcomm/qcs405/gpio.c M src/soc/qualcomm/qcs405/i2c.c M src/soc/qualcomm/sdm845/usb.c 7 files changed, 1 insertion(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/34230/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34230 )
Change subject: src: Remove unneeded 'include <delay.h>' ......................................................................
Patch Set 2: Code-Review+2
Hello Julius Werner, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34230
to look at the new patch set (#3).
Change subject: src: Remove unneeded 'include <delay.h>' ......................................................................
src: Remove unneeded 'include <delay.h>'
Change-Id: Ibf91c35aa389a91116463616a778212bb386756e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/ipmi/ipmi_kcs_ops.c M src/mainboard/getac/p470/mainboard.c M src/soc/mediatek/common/rtc.c M src/soc/qualcomm/qcs405/clock.c M src/soc/qualcomm/qcs405/gpio.c M src/soc/qualcomm/qcs405/i2c.c M src/soc/qualcomm/sdm845/usb.c 7 files changed, 1 insertion(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/34230/3
Hello Julius Werner, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34230
to look at the new patch set (#4).
Change subject: src: Remove unneeded 'include <delay.h>' ......................................................................
src: Remove unneeded 'include <delay.h>'
Change-Id: Ibf91c35aa389a91116463616a778212bb386756e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/getac/p470/mainboard.c M src/soc/mediatek/common/rtc.c M src/soc/qualcomm/qcs405/clock.c M src/soc/qualcomm/qcs405/gpio.c M src/soc/qualcomm/qcs405/i2c.c M src/soc/qualcomm/sdm845/usb.c 6 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/34230/4
Hello Julius Werner, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34230
to look at the new patch set (#8).
Change subject: src: Remove unneeded 'include <delay.h>' ......................................................................
src: Remove unneeded 'include <delay.h>'
Change-Id: Ibf91c35aa389a91116463616a778212bb386756e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/getac/p470/mainboard.c M src/soc/mediatek/common/rtc.c M src/soc/qualcomm/qcs405/clock.c M src/soc/qualcomm/qcs405/gpio.c M src/soc/qualcomm/qcs405/i2c.c M src/soc/qualcomm/sdm845/usb.c 6 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/34230/8
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34230 )
Change subject: src: Remove unneeded 'include <delay.h>' ......................................................................
Patch Set 10: Code-Review+1
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34230 )
Change subject: src: Remove unneeded 'include <delay.h>' ......................................................................
Patch Set 10: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/34230 )
Change subject: src: Remove unneeded 'include <delay.h>' ......................................................................
src: Remove unneeded 'include <delay.h>'
Change-Id: Ibf91c35aa389a91116463616a778212bb386756e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/34230 Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/getac/p470/mainboard.c M src/soc/mediatek/common/rtc.c M src/soc/qualcomm/qcs405/clock.c M src/soc/qualcomm/qcs405/gpio.c M src/soc/qualcomm/qcs405/i2c.c M src/soc/qualcomm/sdm845/usb.c 6 files changed, 0 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Frans Hendriks: Looks good to me, but someone else must approve
diff --git a/src/mainboard/getac/p470/mainboard.c b/src/mainboard/getac/p470/mainboard.c index 813b1d6..da90349 100644 --- a/src/mainboard/getac/p470/mainboard.c +++ b/src/mainboard/getac/p470/mainboard.c @@ -17,7 +17,6 @@ #include <device/device.h> #include <device/pci_def.h> #include <device/pci_ops.h> -#include <delay.h> #include <drivers/intel/gma/int15.h>
diff --git a/src/soc/mediatek/common/rtc.c b/src/soc/mediatek/common/rtc.c index fe252b5..080f334 100644 --- a/src/soc/mediatek/common/rtc.c +++ b/src/soc/mediatek/common/rtc.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <delay.h> #include <soc/rtc_common.h> #include <soc/rtc.h> #include <soc/pmic_wrap.h> diff --git a/src/soc/qualcomm/qcs405/clock.c b/src/soc/qualcomm/qcs405/clock.c index da2e8a4..28f1bc1 100644 --- a/src/soc/qualcomm/qcs405/clock.c +++ b/src/soc/qualcomm/qcs405/clock.c @@ -15,7 +15,6 @@ #include <console/console.h> #include <device/mmio.h> #include <types.h> -#include <delay.h> #include <commonlib/helpers.h> #include <soc/clock.h>
diff --git a/src/soc/qualcomm/qcs405/gpio.c b/src/soc/qualcomm/qcs405/gpio.c index 19027c3..5eb9964 100644 --- a/src/soc/qualcomm/qcs405/gpio.c +++ b/src/soc/qualcomm/qcs405/gpio.c @@ -15,7 +15,6 @@
#include <device/mmio.h> #include <types.h> -#include <delay.h> #include <gpio.h>
void gpio_configure(gpio_t gpio, uint32_t func, uint32_t pull, diff --git a/src/soc/qualcomm/qcs405/i2c.c b/src/soc/qualcomm/qcs405/i2c.c index 94f8e0d..77c381c 100644 --- a/src/soc/qualcomm/qcs405/i2c.c +++ b/src/soc/qualcomm/qcs405/i2c.c @@ -31,7 +31,6 @@
#include <assert.h> #include <console/console.h> -#include <delay.h> #include <device/i2c_simple.h> #include <stdlib.h> #include <string.h> diff --git a/src/soc/qualcomm/sdm845/usb.c b/src/soc/qualcomm/sdm845/usb.c index 56da28e..974fbec 100644 --- a/src/soc/qualcomm/sdm845/usb.c +++ b/src/soc/qualcomm/sdm845/usb.c @@ -15,7 +15,6 @@
#include <stdlib.h> #include <console/console.h> -#include <delay.h> #include <device/mmio.h> #include <soc/usb.h> #include <soc/clock.h>