Andrey Petrov has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40552 )
Change subject: soc/intel/xeon_sp/cpx: Allow motherboards to set FSP-M parameters ......................................................................
soc/intel/xeon_sp/cpx: Allow motherboards to set FSP-M parameters
We need to allow motherboards to configure certain parameters that are specific to it. Hence, invoke this function. Also, provide a weak motherboard implementation that does nothing.
Change-Id: Ifa2824811273236a66e742404856fbe17d4cf496 Signed-off-by: Andrey Petrov anpetrov@fb.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40552 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Maxim Polyakov max.senia.poliak@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/xeon_sp/cpx/romstage.c M src/soc/intel/xeon_sp/romstage.c 2 files changed, 8 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Maxim Polyakov: Looks good to me, approved
diff --git a/src/soc/intel/xeon_sp/cpx/romstage.c b/src/soc/intel/xeon_sp/cpx/romstage.c index 32ada9f..e909b87 100644 --- a/src/soc/intel/xeon_sp/cpx/romstage.c +++ b/src/soc/intel/xeon_sp/cpx/romstage.c @@ -3,6 +3,7 @@
#include <arch/romstage.h> #include <fsp/api.h> +#include <soc/romstage.h> #include "chip.h"
void platform_fsp_memory_init_params_cb(FSPM_UPD *mupd, uint32_t version) @@ -10,4 +11,6 @@ FSP_M_CONFIG *m_cfg = &mupd->FspmConfig;
(void)m_cfg; + + mainboard_memory_init_params(mupd); } diff --git a/src/soc/intel/xeon_sp/romstage.c b/src/soc/intel/xeon_sp/romstage.c index 9d3665c..7881b0a 100644 --- a/src/soc/intel/xeon_sp/romstage.c +++ b/src/soc/intel/xeon_sp/romstage.c @@ -55,3 +55,8 @@
run_postcar_phase(&pcf); } + +__weak void mainboard_memory_init_params(FSPM_UPD *mupd) +{ + printk(BIOS_SPEW, "WARNING: using default FSP-M parameters!\n"); +}