Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46655 )
Change subject: mb/google/zork: update telemetry settings for morphius ......................................................................
mb/google/zork: update telemetry settings for morphius
Update the two load line slope settings for the SVID3 telemetry. AGESA sends these values to the SMU, which accepts them as units of current. Proper calibration is determined by the AMD SDLE tool and the Stardust test.
VDD Slope: 62852 -> 62641 SOC Slope: 28022 -> 28333
BUG=b:170531252 BRANCH=zork TEST=1. emerge-zork coreboot 2. pass AMD SDLE/Stardust test
Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Change-Id: Id831907aa47be27fef2e33bb884a1118ffec14a0 --- M src/mainboard/google/zork/variants/morphius/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/46655/1
diff --git a/src/mainboard/google/zork/variants/morphius/overridetree.cb b/src/mainboard/google/zork/variants/morphius/overridetree.cb index 66b371b..e04a62e 100644 --- a/src/mainboard/google/zork/variants/morphius/overridetree.cb +++ b/src/mainboard/google/zork/variants/morphius/overridetree.cb @@ -16,9 +16,9 @@ register "sustained_power_limit" = "12000" #mw register "thermctl_limit" = "100" #degrees C
- register "telemetry_vddcr_vdd_slope" = "62852" #mA + register "telemetry_vddcr_vdd_slope" = "62641" #mA register "telemetry_vddcr_vdd_offset" = "0" - register "telemetry_vddcr_soc_slope" = "28022" #mA + register "telemetry_vddcr_soc_slope" = "28333" #mA register "telemetry_vddcr_soc_offset" = "0"
# Set STAPM confiuration for tablet mode
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46655 )
Change subject: mb/google/zork: update telemetry settings for morphius ......................................................................
Patch Set 1: Code-Review+2
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46655 )
Change subject: mb/google/zork: update telemetry settings for morphius ......................................................................
Patch Set 1: Code-Review+2
Keith Tzeng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46655 )
Change subject: mb/google/zork: update telemetry settings for morphius ......................................................................
Patch Set 1:
Please help land this and carry to chromium tree, thanks.
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46655 )
Change subject: mb/google/zork: update telemetry settings for morphius ......................................................................
mb/google/zork: update telemetry settings for morphius
Update the two load line slope settings for the SVID3 telemetry. AGESA sends these values to the SMU, which accepts them as units of current. Proper calibration is determined by the AMD SDLE tool and the Stardust test.
VDD Slope: 62852 -> 62641 SOC Slope: 28022 -> 28333
BUG=b:170531252 BRANCH=zork TEST=1. emerge-zork coreboot 2. pass AMD SDLE/Stardust test
Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Change-Id: Id831907aa47be27fef2e33bb884a1118ffec14a0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/46655 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/mainboard/google/zork/variants/morphius/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Marshall Dawson: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/morphius/overridetree.cb b/src/mainboard/google/zork/variants/morphius/overridetree.cb index 66b371b..e04a62e 100644 --- a/src/mainboard/google/zork/variants/morphius/overridetree.cb +++ b/src/mainboard/google/zork/variants/morphius/overridetree.cb @@ -16,9 +16,9 @@ register "sustained_power_limit" = "12000" #mw register "thermctl_limit" = "100" #degrees C
- register "telemetry_vddcr_vdd_slope" = "62852" #mA + register "telemetry_vddcr_vdd_slope" = "62641" #mA register "telemetry_vddcr_vdd_offset" = "0" - register "telemetry_vddcr_soc_slope" = "28022" #mA + register "telemetry_vddcr_soc_slope" = "28333" #mA register "telemetry_vddcr_soc_offset" = "0"
# Set STAPM confiuration for tablet mode
-
Felix Held (Code Review) -
Keith Tzeng (Code Review)
-
Kevin Chiu (Code Review)
-
Marshall Dawson (Code Review)
-
Martin Roth (Code Review)