Attention is currently required from: V Sowmya, Tim Wawrzynczak, Alex Levin, Sugnan Prabhu S, Rizwan Qureshi, Subramony Sesha (Anand), Ruben Rodriguez Buchillon, Aamir Bohra, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51274 )
Change subject: soc/intel/alderlake/acpi: Skip D3Cold for TBT
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51274/comment/82f116ef_7b07af2f
PS3, Line 9: Includes change to skip D3Cold when TBT is in disconnected state which
: was blocking the S0ix state transition.
Let's please address the opens and understand the reason for this change before pushing this in.
Marking as resolved for now to move this change forward for validation. But, I would still like to get the opens answered.
File src/soc/intel/alderlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/51274/comment/3ed870bd_21349f68
PS3, Line 616: _SB.PCI0.TDM1.IFWR()
The IFWR Method doesn't seem to be necessary, you could just check `_SB.PCI0.TDM1. […]
Sugnan - can you please address Tim's comment? We can go ahead and land this to unblock the validation. But, let's continue addressing the opens in b/183670327 even after this change lands.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51274
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9b9ceee4393aeba37fdcb4e05d1b279a6ff72d2
Gerrit-Change-Number: 51274
Gerrit-PatchSet: 3
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Alex Levin
levinale@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ruben Rodriguez Buchillon
coconutruben@google.com
Gerrit-Reviewer: Subramony Sesha (Anand)
subramony.sesha@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Archana Patni
archana.patni@intel.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Alex Levin
levinale@google.com
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Subramony Sesha (Anand)
subramony.sesha@intel.com
Gerrit-Attention: Ruben Rodriguez Buchillon
coconutruben@google.com
Gerrit-Attention: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 08 Apr 2021 15:29:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment