Attention is currently required from: Shelley Chen, Ravi Kumar Bokka, Paul Menzel, Julius Werner. Vinod Polimera has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61342 )
Change subject: qualcomm/sc7280: Add support for edp and mdp driver ......................................................................
Patch Set 21:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61342/comment/cfc26245_bd0c8483 PS1, Line 8:
Please elaborate, how it is implemented.
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/61342/comment/b2825953_06adc322 PS2, Line 9: BUG=b:182963902
syntax is BUG=b:182963902, b:216687885
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/61342/comment/1307b4a3_27f11d5c PS7, Line 10: TEST=Validated on qualcomm sc7280 development board.
Please elaborate on how you tested this. When I apply this patch, I was seeing a malloc error. […]
Done
https://review.coreboot.org/c/coreboot/+/61342/comment/5b7850eb_c5efbb15 PS7, Line 10: development
development
Done
File src/mainboard/google/herobrine/mainboard.c:
https://review.coreboot.org/c/coreboot/+/61342/comment/97a599ff_91fb6e4c PS2, Line 61: if (display_init_required()) {
suspect code indent for conditional statements (8, 24) […]
Done
File src/soc/qualcomm/sc7280/display/edp_ctrl.c:
https://review.coreboot.org/c/coreboot/+/61342/comment/51c71d80_239d1929 PS13, Line 363: GPIO_PULL_DOWN, GPIO_2MA, GPIO_INPUT);
Unless you're explicitly trying to set a non-standard drive strength, you're supposed to just use gp […]
Done
https://review.coreboot.org/c/coreboot/+/61342/comment/8d454665_dd7ca082 PS13, Line 360: gpio_output(GPIO(80), 1); : mdelay(20); : gpio_configure(GPIO(60), GPIO_FUNC_GPIO, : GPIO_PULL_DOWN, GPIO_2MA, GPIO_INPUT); : mdelay(10); : gpio_output(GPIO(8), 1); : mdelay(20);
These almost certainly don't belong here anyway (maybe the HPD, if that's the only pin the SoC can p […]
Done
-
Vinod Polimera (Code Review)