Attention is currently required from: Konrad Adamczyk, Raul Rangel, Jakub Czapiga, Matt DeVillier, Paul Menzel, Grzegorz Bernacki, Fred Reitberger, Felix Held.
Hello Jason Glenesk, build bot (Jenkins), Konrad Adamczyk, Raul Rangel, Jakub Czapiga, Matt DeVillier, Paul Menzel, Tim Van Patten, Fred Reitberger, Karthik Ramasubramanian, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74779
to look at the new patch set (#2).
Change subject: soc/amd/common/block/graphics: Add missing cbfs_unmap()
......................................................................
soc/amd/common/block/graphics: Add missing cbfs_unmap()
pci_rom_probe() can allocate memory when mapping a CBFS
file, so pci_rom_free() should be called before leaving
the function.
BUG=278264488
TEST=Build and run with additional debug prints added
to confirm that data are correctly unmapped
Change-Id: Ie6fbbfd36f0974551befef4d08423a8148e151e7
Signed-off-by: Grzegorz Bernacki bernacki@google.com
---
M src/soc/amd/common/block/graphics/graphics.c
1 file changed, 31 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/74779/2
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74779
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6fbbfd36f0974551befef4d08423a8148e151e7
Gerrit-Change-Number: 74779
Gerrit-PatchSet: 2
Gerrit-Owner: Grzegorz Bernacki
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Konrad Adamczyk
konrada@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Konrad Adamczyk
konrada@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Grzegorz Bernacki
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: newpatchset