Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21120 )
Change subject: sb/intel/common: SMBus complete_command()
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/#/c/21120/11/src/southbridge/intel/common/smbus....
File src/southbridge/intel/common/smbus.c:
https://review.coreboot.org/#/c/21120/11/src/southbridge/intel/common/smbus....
PS11, Line 85: static int cb_err_from_stat(u8 status)
: {
: /* Ignore the "In Use" status... */
: status &= ~(SMBHSTSTS_SMBALERT_STS | SMBHSTSTS_INUSE_STS);
:
: if (status == SMBHSTSTS_INTR)
: return 0;
:
: return SMBUS_ERROR;
: }
this seems to have false positives on at least ich10 with i2c_block_read.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/21120
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idea15e03edde7aeedf198c1529f09c24a5bc0b06
Gerrit-Change-Number: 21120
Gerrit-PatchSet: 11
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 04 Feb 2019 15:36:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment