Change in coreboot[master]: Jinlon: Configure GPP_E0 as output

[Rajat Jain (Code Review)]

Rajat Jain has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39144 )

Change subject: Jinlon: Configure GPP_E0 as output
......................................................................

Jinlon: Configure GPP_E0 as output

Configure GPP_E0 as output on Jinlon

Change-Id: Iad640eed855b47e365da55fa994c6a3c4c38caf9
Signed-off-by: Rajat Jain .
---
M src/mainboard/google/hatch/variants/jinlon/gpio.c
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/39144/1

diff --git a/src/mainboard/google/hatch/variants/jinlon/gpio.c b/src/mainboard/google/hatch/variants/jinlon/gpio.c
index 2bf97b1..c584d94 100644
--- a/src/mainboard/google/hatch/variants/jinlon/gpio.c
+++ b/src/mainboard/google/hatch/variants/jinlon/gpio.c
@@ -31,6 +31,8 @@
     * using this pin, expose this pin to driver.
     */
    PAD_CFG_GPO(GPP_C15, 1, DEEP),
+	/* E0 : View Angle Management */
+	PAD_CFG_GPO(GPP_E0, 0, DEEP),
    /* F3  : MEM_STRAP_3 */
    PAD_CFG_GPI(GPP_F3, NONE, PLTRST),
    /* F10 : MEM_STRAP_2 */

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39144 )

Change subject: Jinlon: Configure GPP_E0 as output
......................................................................

Patch Set 1: Code-Review+2

[Rajat Jain (Code Review)]

Rajat Jain has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39144 )

Change subject: Jinlon: Configure GPP_E0 as output
......................................................................

Patch Set 1:

What happens to this now? Do I need to flip any label in order to have this committed? (I don't have permission to change the "Verified" label.

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39144 )

Change subject: Jinlon: Configure GPP_E0 as output
......................................................................

Patch Set 1: Code-Review+2
> Patch Set 1:
>
> What happens to this now? Do I need to flip any label in order to have this committed? (I don't have permission to change the "Verified" label.

Somebody with submit rights (pgeorgi, furquan, shchen, etc.) can submit the CL. The coreboot CI system (build bot or Jenkins) is what provides the Verified, meaning it compiles for all boards. And you also have to resolve all the comments before it can be submitted too.

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39144 )

Change subject: Jinlon: Configure GPP_E0 as output
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39144/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39144/1//COMMIT_MSG@7 
PS1, Line 7: Jinlon
Please use the correct prefix for variants.

https://review.coreboot.org/c/coreboot/+/39144/1//COMMIT_MSG@9 
PS1, Line 9: Configure GPP_E0 as output on Jinlon
Why?

Change in coreboot[master]: mb/google/hatch/var/jinlon: Configure GPP_E0 as output

[Rajat Jain (Code Review)]

Hello Tim Wawrzynczak, Mathew King, Tim Wawrzynczak, Duncan Laurie, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39144

to look at the new patch set (#2).

Change subject: mb/google/hatch/var/jinlon: Configure GPP_E0 as output
......................................................................

mb/google/hatch/var/jinlon: Configure GPP_E0 as output

Configure GPP_E0 as output for view angle management

Change-Id: Iad640eed855b47e365da55fa994c6a3c4c38caf9
Signed-off-by: Rajat Jain .
---
M src/mainboard/google/hatch/variants/jinlon/gpio.c
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/39144/2

Change in coreboot[master]: mb/google/hatch/var/jinlon: Configure GPP_E0 as output

[Rajat Jain (Code Review)]

Rajat Jain has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39144 )

Change subject: mb/google/hatch/var/jinlon: Configure GPP_E0 as output
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39144/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39144/1//COMMIT_MSG@7 
PS1, Line 7: Jinlon
> Please use the correct prefix for variants.

Done

https://review.coreboot.org/c/coreboot/+/39144/1//COMMIT_MSG@9 
PS1, Line 9: Configure GPP_E0 as output on Jinlon
> Why?

Done

Change in coreboot[master]: mb/google/hatch/var/jinlon: Configure GPP_E0 as output

[Furquan Shaikh (Code Review)]

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39144 )

Change subject: mb/google/hatch/var/jinlon: Configure GPP_E0 as output
......................................................................

mb/google/hatch/var/jinlon: Configure GPP_E0 as output

Configure GPP_E0 as output for view angle management

Change-Id: Iad640eed855b47e365da55fa994c6a3c4c38caf9
Signed-off-by: Rajat Jain .
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39144
Tested-by: build bot (Jenkins) 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Tim Wawrzynczak 
---
M src/mainboard/google/hatch/variants/jinlon/gpio.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/jinlon/gpio.c b/src/mainboard/google/hatch/variants/jinlon/gpio.c
index 2bf97b1..c584d94 100644
--- a/src/mainboard/google/hatch/variants/jinlon/gpio.c
+++ b/src/mainboard/google/hatch/variants/jinlon/gpio.c
@@ -31,6 +31,8 @@
     * using this pin, expose this pin to driver.
     */
    PAD_CFG_GPO(GPP_C15, 1, DEEP),
+	/* E0 : View Angle Management */
+	PAD_CFG_GPO(GPP_E0, 0, DEEP),
    /* F3  : MEM_STRAP_3 */
    PAD_CFG_GPI(GPP_F3, NONE, PLTRST),
    /* F10 : MEM_STRAP_2 */

Change in coreboot[master]: mb/google/hatch/var/jinlon: Configure GPP_E0 as output

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39144 )

Change subject: mb/google/hatch/var/jinlon: Configure GPP_E0 as output
......................................................................

Patch Set 3:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3
Emulation targets:
EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/926
EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/925
EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/924

Please note: This test is under development and might not be accurate at all!