Change in coreboot[master]: soc/amd/{picasso,stoneyridge}/romstage.c: Use post_codes macros
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45526 )
Change subject: soc/amd/{picasso,stoneyridge}/romstage.c: Use post_codes macros ......................................................................
soc/amd/{picasso,stoneyridge}/romstage.c: Use post_codes macros
Change-Id: I51782996602a4ae17058e6ff85d4e05f751a2bfd Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/amd/picasso/romstage.c M src/soc/amd/stoneyridge/romstage.c 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/45526/1
diff --git a/src/soc/amd/picasso/romstage.c b/src/soc/amd/picasso/romstage.c index b967431..09fc987 100644 --- a/src/soc/amd/picasso/romstage.c +++ b/src/soc/amd/picasso/romstage.c @@ -145,7 +145,7 @@ { int s3_resume;
- post_code(0x40); + post_code(POST_CONSOLE_BOOT_MSG); console_init();
post_code(0x41); diff --git a/src/soc/amd/stoneyridge/romstage.c b/src/soc/amd/stoneyridge/romstage.c index 96103ef..0940569 100644 --- a/src/soc/amd/stoneyridge/romstage.c +++ b/src/soc/amd/stoneyridge/romstage.c @@ -69,7 +69,7 @@ bsp_agesa_call();
if (!s3_resume) { - post_code(0x40); + post_code(POST_CONSOLE_BOOT_MSG); do_agesawrapper(AMD_INIT_POST, "amdinitpost");
post_code(0x41); @@ -102,7 +102,7 @@ wrmsr(SYSCFG_MSR, sys_cfg); } else { printk(BIOS_INFO, "S3 detected\n"); - post_code(0x60); + post_code(POST_ENABLING_CACHE); do_agesawrapper(AMD_INIT_RESUME, "amdinitresume");
post_code(0x61);
Attention is currently required from: Jason Glenesk, Marshall Dawson, HAOUAS Elyes, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45526 )
Change subject: soc/amd/{picasso,stoneyridge}/romstage.c: Use post_codes macros ......................................................................
Patch Set 3: Code-Review+1
Attention is currently required from: Jason Glenesk, HAOUAS Elyes, Felix Held. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45526 )
Change subject: soc/amd/{picasso,stoneyridge}/romstage.c: Use post_codes macros ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3: Is a similar change going into other SOCs? For what it's worth, it seems like a more appropriate location for POST_CONSOLE_BOOT_MSG would be in lib/bootblock.c after console_init(). Or potentially in bootblock_soc_init() in the soc directories.
Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45526 )
Change subject: soc/amd/{picasso,stoneyridge}/romstage.c: Use post_codes macros ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Is a similar change going into other SOCs? For what it's worth, it seems like a more appropriate lo […]
no, I'm not working on it. I've just removed the "conflict status" of this current old patch.
Yes, it makes sense for POST_CONSOLE_BOOT_MSG location.
Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Marshall Dawson, Paul Menzel, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45526
to look at the new patch set (#5).
Change subject: soc/amd/stoneyridge/romstage.c: Use post_codes macros ......................................................................
soc/amd/stoneyridge/romstage.c: Use post_codes macros
Change-Id: I51782996602a4ae17058e6ff85d4e05f751a2bfd Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/amd/stoneyridge/romstage.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/45526/5
-
HAOUAS Elyes (Code Review) -
Marshall Dawson (Code Review)
-
Paul Menzel (Code Review)