Change in coreboot[master]: stage_cache: Add more empty stubs functions

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34651 )

Change subject: stage_cache: Add more empty stubs functions
......................................................................

stage_cache: Add more empty stubs functions

Added for symmetry with other stage_cache_add()
command variants, currently for amd/stoneyridge.

Change-Id: I580054104a61f1b03ba36a7c97ad4411c3d29855
Signed-off-by: Kyösti Mälkki 
---
M src/include/stage_cache.h
1 file changed, 10 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/34651/1

diff --git a/src/include/stage_cache.h b/src/include/stage_cache.h
index 192cfb9..3483c0c 100644
--- a/src/include/stage_cache.h
+++ b/src/include/stage_cache.h
@@ -38,15 +38,20 @@
 void stage_cache_add(int stage_id, const struct prog *stage);
 /* Load the cached stage at given location returning the stage entry point. */
 void stage_cache_load_stage(int stage_id, struct prog *stage);
-#else /* CONFIG_NO_STAGE_CACHE */
-static inline void stage_cache_add(int stage_id, const struct prog *stage) {}
-static inline void stage_cache_load_stage(int stage_id, struct prog *stage) {}
-#endif
-
 /* Cache non-specific data or code. */
 void stage_cache_add_raw(int stage_id, const void *base, const size_t size);
 /* Get a pointer to cached raw data and its size. */
 void stage_cache_get_raw(int stage_id, void **base, size_t *size);
+
+#else /* CONFIG_NO_STAGE_CACHE */
+
+static inline void stage_cache_add(int stage_id, const struct prog *stage) {}
+static inline void stage_cache_load_stage(int stage_id, struct prog *stage) {}
+static inline void stage_cache_add_raw(int stage_id, const void *base, const size_t size) {}
+static inline void stage_cache_get_raw(int stage_id, void **base, size_t *size) {}
+
+#endif
+
 /* Fill in parameters for the external stage cache, if utilized. */
 void stage_cache_external_region(void **base, size_t *size);

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34651 )

Change subject: stage_cache: Add more empty stubs functions
......................................................................

Patch Set 1: Code-Review+2

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34651 )

Change subject: stage_cache: Add more empty stubs functions
......................................................................

Patch Set 1: Code-Review+2

[Subrata Banik (Code Review)]

Subrata Banik has uploaded a new patch set (#2) to the change originally created by Kyösti Mälkki. ( https://review.coreboot.org/c/coreboot/+/34651 )

Change subject: stage_cache: Add more empty stubs functions
......................................................................

stage_cache: Add more empty stubs functions

Added for symmetry with other stage_cache_add()
command variants, currently for amd/stoneyridge.

Change-Id: I580054104a61f1b03ba36a7c97ad4411c3d29855
Signed-off-by: Kyösti Mälkki 
---
M src/include/stage_cache.h
1 file changed, 10 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/34651/2

[Subrata Banik (Code Review)]

Subrata Banik has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34651 )

Change subject: stage_cache: Add more empty stubs functions
......................................................................

stage_cache: Add more empty stubs functions

Added for symmetry with other stage_cache_add()
command variants, currently for amd/stoneyridge.

Change-Id: I580054104a61f1b03ba36a7c97ad4411c3d29855
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34651
Reviewed-by: Furquan Shaikh 
Reviewed-by: Subrata Banik 
Tested-by: build bot (Jenkins) 
---
M src/include/stage_cache.h
1 file changed, 10 insertions(+), 5 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Subrata Banik: Looks good to me, approved

diff --git a/src/include/stage_cache.h b/src/include/stage_cache.h
index 192cfb9..3483c0c 100644
--- a/src/include/stage_cache.h
+++ b/src/include/stage_cache.h
@@ -38,15 +38,20 @@
 void stage_cache_add(int stage_id, const struct prog *stage);
 /* Load the cached stage at given location returning the stage entry point. */
 void stage_cache_load_stage(int stage_id, struct prog *stage);
-#else /* CONFIG_NO_STAGE_CACHE */
-static inline void stage_cache_add(int stage_id, const struct prog *stage) {}
-static inline void stage_cache_load_stage(int stage_id, struct prog *stage) {}
-#endif
-
 /* Cache non-specific data or code. */
 void stage_cache_add_raw(int stage_id, const void *base, const size_t size);
 /* Get a pointer to cached raw data and its size. */
 void stage_cache_get_raw(int stage_id, void **base, size_t *size);
+
+#else /* CONFIG_NO_STAGE_CACHE */
+
+static inline void stage_cache_add(int stage_id, const struct prog *stage) {}
+static inline void stage_cache_load_stage(int stage_id, struct prog *stage) {}
+static inline void stage_cache_add_raw(int stage_id, const void *base, const size_t size) {}
+static inline void stage_cache_get_raw(int stage_id, void **base, size_t *size) {}
+
+#endif
+
 /* Fill in parameters for the external stage cache, if utilized. */
 void stage_cache_external_region(void **base, size_t *size);

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34651 )

Change subject: stage_cache: Add more empty stubs functions
......................................................................

Patch Set 3:

Subrata, leave it to me to submit my changes. Also, you broke the 24 hour rule here...

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34651 )

Change subject: stage_cache: Add more empty stubs functions
......................................................................

Patch Set 3:
> Patch Set 3:
>
> Subrata, leave it to me to submit my changes. Also, you broke the 24 hour rule here...

i need to make my changes, so its too much to rebase your CL every time, i submit my new patchset.

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34651 )

Change subject: stage_cache: Add more empty stubs functions
......................................................................

Patch Set 3:
> Patch Set 3:
> > Patch Set 3:
> >
> > Subrata, leave it to me to submit my changes. Also, you broke the 24 hour rule here...
>
> i need to make my changes, so its too much to rebase your CL every time, i submit my new patchset.

There is nothing critical about this stage_cache change to make that excuse.

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34651 )

Change subject: stage_cache: Add more empty stubs functions
......................................................................

Patch Set 3:
> Patch Set 3:
> > Patch Set 3:
> > > Patch Set 3:
> > >
> > > Subrata, leave it to me to submit my changes. Also, you broke the 24 hour rule here...
> >
> > i need to make my changes, so its too much to rebase your CL every time, i submit my new patchset.
>
> There is nothing critical about this stage_cache change to make that excuse.

"critical" is related term, might not relevant to you but its much needed for my work. And we are preciously talking about ~1hr to meet 24hr rule. Its that overnight might be sufficient enough ?