Subrata Banik merged this change.

View Change

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Subrata Banik: Looks good to me, approved
stage_cache: Add more empty stubs functions

Added for symmetry with other stage_cache_add()
command variants, currently for amd/stoneyridge.

Change-Id: I580054104a61f1b03ba36a7c97ad4411c3d29855
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34651
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Subrata Banik <subrata.banik@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/include/stage_cache.h
1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/src/include/stage_cache.h b/src/include/stage_cache.h
index 192cfb9..3483c0c 100644
--- a/src/include/stage_cache.h
+++ b/src/include/stage_cache.h
@@ -38,15 +38,20 @@
void stage_cache_add(int stage_id, const struct prog *stage);
/* Load the cached stage at given location returning the stage entry point. */
void stage_cache_load_stage(int stage_id, struct prog *stage);
-#else /* CONFIG_NO_STAGE_CACHE */
-static inline void stage_cache_add(int stage_id, const struct prog *stage) {}
-static inline void stage_cache_load_stage(int stage_id, struct prog *stage) {}
-#endif
-
/* Cache non-specific data or code. */
void stage_cache_add_raw(int stage_id, const void *base, const size_t size);
/* Get a pointer to cached raw data and its size. */
void stage_cache_get_raw(int stage_id, void **base, size_t *size);
+
+#else /* CONFIG_NO_STAGE_CACHE */
+
+static inline void stage_cache_add(int stage_id, const struct prog *stage) {}
+static inline void stage_cache_load_stage(int stage_id, struct prog *stage) {}
+static inline void stage_cache_add_raw(int stage_id, const void *base, const size_t size) {}
+static inline void stage_cache_get_raw(int stage_id, void **base, size_t *size) {}
+
+#endif
+
/* Fill in parameters for the external stage cache, if utilized. */
void stage_cache_external_region(void **base, size_t *size);


To view, visit change 34651. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I580054104a61f1b03ba36a7c97ad4411c3d29855
Gerrit-Change-Number: 34651
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged