Attention is currently required from: Nico Huber, Furquan Shaikh, Angel Pons, Tim Wawrzynczak, Patrick Rudolph.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55341 )
Change subject: drivers/intel/gma: Move extended VBT just below opregion
......................................................................
Patch Set 3:
(2 comments)
File src/drivers/intel/gma/opregion.c:
https://review.coreboot.org/c/coreboot/+/55341/comment/3991b247_4757014a
PS2, Line 271: static void opregion_add_ext_vbt(igd_opregion_t *opregion, uint8_t *ext_vbt, optionrom_vbt_t *vbt)
Does this need to be a separate function?
Ack. Yes Angel, Actually we're planning to scale it and use it for OPREGION 2.1 as well.
In case of 2.1 version, we need to pass relative address of VBT in RVDA as opposed to actual address. So to handle this case, I am making it as a separate function so that we won't clutter base function with conditions.
https://review.coreboot.org/c/coreboot/+/55341/comment/14436d78_b74c3a04
PS2, Line 288: uint32_t
`size_t` would be more accurate. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55341
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0e255df63145409096b0b9312c6c51c05f49931
Gerrit-Change-Number: 55341
Gerrit-PatchSet: 3
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 09 Jun 2021 14:43:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment