build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22604 )
Change subject: cpu/intel/speedstep/acpi.c: Add Netburst CPUs ......................................................................
Patch Set 19:
(6 comments)
https://review.coreboot.org/#/c/22604/19/src/cpu/intel/speedstep/acpi.c File src/cpu/intel/speedstep/acpi.c:
https://review.coreboot.org/#/c/22604/19/src/cpu/intel/speedstep/acpi.c@92 PS19, Line 92: else else is not generally useful after a break or return
https://review.coreboot.org/#/c/22604/19/src/cpu/intel/speedstep/speedstep.c File src/cpu/intel/speedstep/speedstep.c:
https://review.coreboot.org/#/c/22604/19/src/cpu/intel/speedstep/speedstep.c... PS19, Line 45: if (((rdmsr(MSR_EXTENDED_CONFIG).lo >> 27) & 3) == 3) {/*supported and line over 80 characters
https://review.coreboot.org/#/c/22604/19/src/cpu/intel/speedstep/speedstep.c... PS19, Line 46: enabled bits */ line over 80 characters
https://review.coreboot.org/#/c/22604/19/src/cpu/intel/speedstep/speedstep.c... PS19, Line 48: params->slfm = SPEEDSTEP_STATE_FROM_MSR(msr.lo, state_mask); line over 80 characters
https://review.coreboot.org/#/c/22604/19/src/cpu/intel/speedstep/speedstep.c... PS19, Line 77: !(rdmsr(IA32_MISC_ENABLES).hi & (1 << (38 - 32)))) { line over 80 characters
https://review.coreboot.org/#/c/22604/19/src/cpu/intel/speedstep/speedstep.c... PS19, Line 79: params->turbo = SPEEDSTEP_STATE_FROM_MSR(msr.hi, state_mask); line over 80 characters
-
build bot (Jenkins) (Code Review)