Change in coreboot[master]: mb/google/brya/var/primus: Fix some GPIO programming - coreboot-gerrit

3 Jan 2022


      Attention is currently required from: Felix Singer, Ariel Fang, Tim Wawrzynczak, Casper Chang.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60104 )
Change subject: mb/google/brya/var/primus: Fix some GPIO programming
......................................................................
Patch Set 25:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60104/comment/7e29815e_d9b021c4 
PS25, Line 17: verify it builds without error
Did you get an error before? If yes, please paste it into the commit message.
File src/mainboard/google/brya/variants/primus/gpio.c:
https://review.coreboot.org/c/coreboot/+/60104/comment/4c8595bb_4eba8877 
PS25, Line 62: 
Why add the blank line?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/60104
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e269bc6fb6eda7b2de57e1a9c900864d3e86e98
Gerrit-Change-Number: 60104
Gerrit-PatchSet: 25
Gerrit-Owner: Ariel Fang ariel_fang@wistron.corp-partner.google.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Casper Chang casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Zoey Wu zoey_wu@wistron.corp-partner.google.com
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Ariel Fang ariel_fang@wistron.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Casper Chang casper_chang@wistron.corp-partner.google.com
Gerrit-Comment-Date: Mon, 03 Jan 2022 07:58:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment