Gaggery Tsai has posted comments on this change. ( https://review.coreboot.org/29553 )
Change subject: mb/google/poppy/variant/atlas: I2C: run trackpad at 1MHz ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/29553/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/29553/1//COMMIT_MSG@15 PS1, Line 15: Data Hold_time larger than 260ns (32 * 8.3ns = 265ns) It shouldn't be 260ns. According to Grant, it should be 0ns for fast plus mode, please double check. Otherwise, the setting now is 20 --> 20*8.3 would less than 265ns.
https://review.coreboot.org/#/c/29553/1//COMMIT_MSG@34 PS1, Line 34: Verified by gaggery.tsai@intel.corp-partner.google.com. : See b/78601949 comment #177 (and many comments up to this one) : : Verified by grundler@chromium.org. : See b/78601949 comment #155, #100, et al. Do we need this in comment?