Change in coreboot[master]: mb/google/mistral: Store developer mode status in coreboot table

[Patrick Georgi (Code Review)]

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34674 )

Change subject: mb/google/mistral: Store developer mode status in coreboot table
......................................................................

mb/google/mistral: Store developer mode status in coreboot table

It's needed downstream and the recent vboot rework dropped the
information when killing the hand-off block.

Change-Id: I411eb8ee6783402db6d4443a6ea1026cf7ad3ae3
Signed-off-by: Patrick Georgi 
---
M src/mainboard/google/mistral/mainboard.c
1 file changed, 21 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/34674/1

diff --git a/src/mainboard/google/mistral/mainboard.c b/src/mainboard/google/mistral/mainboard.c
index d50758c..b350b27 100644
--- a/src/mainboard/google/mistral/mainboard.c
+++ b/src/mainboard/google/mistral/mainboard.c
@@ -14,7 +14,9 @@
  */

#include <device/device.h>
+#include <boot/coreboot_tables.h>
 #include <bootblock_common.h>
+#include <security/vboot/vboot_common.h>
 #include <vendorcode/google/chromeos/chromeos.h>
 #include <soc/usb.h>

@@ -50,3 +52,22 @@
    .name = CONFIG_MAINBOARD_PART_NUMBER,
    .enable_dev = mainboard_enable,
 };
+
+void lb_board(struct lb_header *header)
+{
+	struct lb_modeflags {
+		uint32_t tag;
+		uint32_t size;
+		uint32_t reserved;
+		uint32_t out_flags;
+	} *entry;
+
+	entry = (struct lb_modeflags *)lb_new_record(header);
+	entry->tag = LB_TAG_VBOOT_HANDOFF;
+	entry->size = sizeof(*entry);
+	entry->reserved = 0;
+	entry->out_flags = 0;
+	if (vboot_developer_mode_enabled()) {
+		entry->out_flags |= VB_INIT_OUT_ENABLE_DEVELOPER;
+	}
+}

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34674 )

Change subject: mb/google/mistral: Store developer mode status in coreboot table
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34674/1/src/mainboard/google/mistra... 
File src/mainboard/google/mistral/mainboard.c:

https://review.coreboot.org/c/coreboot/+/34674/1/src/mainboard/google/mistra... 
PS1, Line 70: 	if (vboot_developer_mode_enabled()) {
braces {} are not necessary for single statement blocks

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34674 )

Change subject: mb/google/mistral: Store developer mode status in coreboot table
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34674/3/src/mainboard/google/mistra... 
File src/mainboard/google/mistral/mainboard.c:

https://review.coreboot.org/c/coreboot/+/34674/3/src/mainboard/google/mistra... 
PS3, Line 70: 	if (vboot_developer_mode_enabled()) {
braces {} are not necessary for single statement blocks

[Patrick Georgi (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34674

to look at the new patch set (#4).

Change subject: mb/google/mistral: Store developer mode status in coreboot table
......................................................................

mb/google/mistral: Store developer mode status in coreboot table

It's needed downstream and the recent vboot rework dropped the
information when killing the hand-off block.

Change-Id: I411eb8ee6783402db6d4443a6ea1026cf7ad3ae3
Signed-off-by: Patrick Georgi 
---
M src/mainboard/google/mistral/mainboard.c
1 file changed, 22 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/34674/4

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34674 )

Change subject: mb/google/mistral: Store developer mode status in coreboot table
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34674/4/src/mainboard/google/mistra... 
File src/mainboard/google/mistral/mainboard.c:

https://review.coreboot.org/c/coreboot/+/34674/4/src/mainboard/google/mistra... 
PS4, Line 71: 	if (vboot_developer_mode_enabled()) {
braces {} are not necessary for single statement blocks

[Joel Kitching (Code Review)]

Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34674 )

Change subject: mb/google/mistral: Store developer mode status in coreboot table
......................................................................

Patch Set 4: Code-Review-2

This depends on constants that are slated for deprecation.  Can mistral come up with its own data structure to accomplish this?  Or something general to all ATF requirements?

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34674 )

Change subject: mb/google/mistral: Store developer mode status in coreboot table
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34674/6/src/mainboard/google/mistra... 
File src/mainboard/google/mistral/mainboard.c:

https://review.coreboot.org/c/coreboot/+/34674/6/src/mainboard/google/mistra... 
PS6, Line 71: 	if (vboot_developer_mode_enabled()) {
braces {} are not necessary for single statement blocks

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34674 )

Change subject: mb/google/mistral: Store developer mode status in coreboot table
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34674/7/src/mainboard/google/mistra... 
File src/mainboard/google/mistral/mainboard.c:

https://review.coreboot.org/c/coreboot/+/34674/7/src/mainboard/google/mistra... 
PS7, Line 71: 	if (vboot_developer_mode_enabled()) {
braces {} are not necessary for single statement blocks

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34674 )

Change subject: mb/google/mistral: Store developer mode status in coreboot table
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34674/8/src/mainboard/google/mistra... 
File src/mainboard/google/mistral/mainboard.c:

https://review.coreboot.org/c/coreboot/+/34674/8/src/mainboard/google/mistra... 
PS8, Line 71: 	if (vboot_developer_mode_enabled()) {
braces {} are not necessary for single statement blocks

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34674 )

Change subject: mb/google/mistral: Store developer mode status in coreboot table
......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34674/9/src/mainboard/google/mistra... 
File src/mainboard/google/mistral/mainboard.c:

https://review.coreboot.org/c/coreboot/+/34674/9/src/mainboard/google/mistra... 
PS9, Line 71: 	if (vboot_developer_mode_enabled()) {
braces {} are not necessary for single statement blocks

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34674 )

Change subject: mb/google/mistral: Store developer mode status in coreboot table
......................................................................

Patch Set 10:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34674/10/src/mainboard/google/mistr... 
File src/mainboard/google/mistral/mainboard.c:

https://review.coreboot.org/c/coreboot/+/34674/10/src/mainboard/google/mistr... 
PS10, Line 71: 	if (vboot_developer_mode_enabled()) {
braces {} are not necessary for single statement blocks

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34674 )

Change subject: mb/google/mistral: Store developer mode status in coreboot table
......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34674/11/src/mainboard/google/mistr... 
File src/mainboard/google/mistral/mainboard.c:

https://review.coreboot.org/c/coreboot/+/34674/11/src/mainboard/google/mistr... 
PS11, Line 71: 	if (vboot_developer_mode_enabled()) {
braces {} are not necessary for single statement blocks

[Stefan Reinauer (Code Review)]

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34674 )

Change subject: mb/google/mistral: Store developer mode status in coreboot table
......................................................................

Patch Set 11:

Is this still needed?

[Joel Kitching (Code Review)]

Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34674 )

Change subject: mb/google/mistral: Store developer mode status in coreboot table
......................................................................

Patch Set 11:

In coreboot, the developer mode status should now be retrieved with vboot_get_context()->flags & VB2_CONTEXT_DEVELOPER_MODE.

If some other firmware application needs to access this flag, it may link our vboot_reference library, and use the vboot workbuf stored in cbmem to initialize a context object.

[Patrick Georgi (Code Review)]

Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34674 )

Change subject: mb/google/mistral: Store developer mode status in coreboot table
......................................................................

Abandoned

won't be finished here