Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45905 )
Change subject: drivers/intel/fsp2_0: Integrate FirmwareVersionInfo.h ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45905/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45905/5//COMMIT_MSG@9 PS5, Line 9: From JSL FSP v2376 "FirmwareVersionInfo.h" header file is : added and "FirmwareVersionInfoHob.h" is removed.
Please describe, what the benefits of that new header are. […]
JSL fsp is using FirmwareVersionInfo.h header to fill up the version information and from fsp v2376 this the header file which is included in pkg. to align with it is better to have this header integration in coreboot code also.
https://review.coreboot.org/c/coreboot/+/45905/5//COMMIT_MSG@11 PS5, Line 11: include
included
Done
https://review.coreboot.org/c/coreboot/+/45905/5//COMMIT_MSG@17 PS5, Line 17: TEST=Verify JSLRVP build
Please paste the output with the new header file.
Output will be the same but internal structure had some changes so we had to align with that structure else we would get junk data. JSL will start using this new header file with following patch. i will add output prints there. is it fine ?
https://review.coreboot.org/c/coreboot/+/45907
https://review.coreboot.org/c/coreboot/+/45905/5/src/drivers/intel/fsp2_0/Kc... File src/drivers/intel/fsp2_0/Kconfig.debug_blob:
https://review.coreboot.org/c/coreboot/+/45905/5/src/drivers/intel/fsp2_0/Kc... PS5, Line 46: using new header 'FirmwareVersionInfo.h'.
Can’t this be better integrated? […]
FSP v2376
https://review.coreboot.org/c/coreboot/+/45899
do you want me to add this fsp version details in help ?
-
Ronak Kanabar (Code Review)