Attention is currently required from: Knox Chiou, Yidi Lin, Yu-Ping Wu. zanxi chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64790 )
Change subject: mb/google/corsola: Enable ps8640 for steelix ......................................................................
Patch Set 5:
(4 comments)
Patchset:
PS5: Thanks Yu-Ping, so much. Have verified in steelix board in proto phase.
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/64790/comment/5c02eb5a_7e38d6e4 PS3, Line 125: CONFIG(BOARD_GOOGLE_KINGLER_COMMON) + CONFIG(BOARD_GOOGLE_KRABBY_COMMON) == 1
You'll also need to change this to […]
Done
https://review.coreboot.org/c/coreboot/+/64790/comment/91f6be06_522b4c51 PS3, Line 136: else if (CONFIG(BOARD_GOOGLE_KRABBY) || CONFIG(BOARD_GOOGLE_STEELIX))
If this starts getting complicated, we should make it a Kconfig option. […]
Done
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/64790/comment/a6e42b15_ce150232 PS4, Line 126: "Exactly one of KINGLER and KRABBY must be set");
The string also needs to be updated.
Done
-
zanxi chen (Code Review)