HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36882 )
Change subject: mb/(ich7): Use 'intel/common/acpi/platform.asl' ......................................................................
mb/(ich7): Use 'intel/common/acpi/platform.asl'
Change-Id: I547801efeb91aa2cbe9b4336bf2f3f00b8a8c07c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- D src/mainboard/apple/macbook21/acpi/platform.asl M src/mainboard/apple/macbook21/dsdt.asl D src/mainboard/gigabyte/ga-945gcm-s2l/acpi/platform.asl M src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl D src/mainboard/ibase/mb899/acpi/platform.asl M src/mainboard/ibase/mb899/dsdt.asl D src/mainboard/intel/d945gclf/acpi/platform.asl M src/mainboard/intel/d945gclf/dsdt.asl D src/mainboard/kontron/986lcd-m/acpi/platform.asl M src/mainboard/kontron/986lcd-m/dsdt.asl D src/mainboard/roda/rk886ex/acpi/platform.asl M src/mainboard/roda/rk886ex/dsdt.asl 12 files changed, 0 insertions(+), 360 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/36882/1
diff --git a/src/mainboard/apple/macbook21/acpi/platform.asl b/src/mainboard/apple/macbook21/acpi/platform.asl deleted file mode 100644 index 84807ec..0000000 --- a/src/mainboard/apple/macbook21/acpi/platform.asl +++ /dev/null @@ -1,70 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2007-2009 coresystems GmbH - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of - * the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* The _WAK method is called on system wakeup */ - -Method(_WAK,1) -{ - // CPU specific part - - // Notify PCI Express slots in case a card - // was inserted while a sleep state was active. - - // Are we going to S3? - If (LEqual(Arg0, 3)) { - // .. - } - - // Are we going to S4? - If (LEqual(Arg0, 4)) { - // .. - } - - // TODO: Windows XP SP2 P-State restore - - Return(Package(){0,0}) -} - -/* System Bus */ - -Scope(_SB) -{ - /* This method is placed on the top level, so we can make sure it's the - * first executed _INI method. - */ - Method(_INI, 0) - { - /* The DTS data in NVS is probably not up to date. - * Update temperature values and make sure AP thermal - * interrupts can happen - */ - - // TRAP(71) // TODO - - \GOS() - - /* And the OS workarounds start right after we know what we're - * running: Windows XP SP1 needs to have C-State coordination - * enabled in SMM. - */ - If (LAnd(LEqual(OSYS, 2001), MPEN)) { - // TRAP(61) // TODO - } - - /* SMM power state and C4-on-C3 settings need to be updated */ - // TRAP(43) // TODO - } -} diff --git a/src/mainboard/apple/macbook21/dsdt.asl b/src/mainboard/apple/macbook21/dsdt.asl index 40af217..76457a4 100644 --- a/src/mainboard/apple/macbook21/dsdt.asl +++ b/src/mainboard/apple/macbook21/dsdt.asl @@ -28,9 +28,6 @@ 0x20090419 // OEM revision ) { - // Some generic macros - #include "acpi/platform.asl" - // global NVS and variables #include <southbridge/intel/i82801gx/acpi/globalnvs.asl> #include <southbridge/intel/common/acpi/platform.asl> diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/acpi/platform.asl b/src/mainboard/gigabyte/ga-945gcm-s2l/acpi/platform.asl deleted file mode 100644 index 21eb3df..0000000 --- a/src/mainboard/gigabyte/ga-945gcm-s2l/acpi/platform.asl +++ /dev/null @@ -1,48 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2007-2009 coresystems GmbH - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* The _PTS method (Prepare To Sleep) is called before the OS is - * entering a sleep state. The sleep state number is passed in Arg0 - */ - -Method(_PTS,1) -{ - // Call a trap so SMI can prepare for Sleep as well. - // TRAP(0x55) -} - -/* The _WAK method is called on system wakeup */ - -Method(_WAK,1) -{ - // CPU specific part - - // Notify PCI Express slots in case a card - // was inserted while a sleep state was active. - - // Are we going to S3? - If (LEqual(Arg0, 3)) { - // .. - } - - // Are we going to S4? - If (LEqual(Arg0, 4)) { - // .. - } - - // TODO: Windows XP SP2 P-State restore - - Return(Package(){0,0}) -} diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl b/src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl index afc5386..3b594be 100644 --- a/src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl +++ b/src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl @@ -23,9 +23,6 @@ 0x20090419 // OEM revision ) { - // Some generic macros - #include "acpi/platform.asl" - // global NVS and variables #include <southbridge/intel/i82801gx/acpi/globalnvs.asl> #include <southbridge/intel/common/acpi/platform.asl> diff --git a/src/mainboard/ibase/mb899/acpi/platform.asl b/src/mainboard/ibase/mb899/acpi/platform.asl deleted file mode 100644 index 9866110..0000000 --- a/src/mainboard/ibase/mb899/acpi/platform.asl +++ /dev/null @@ -1,48 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2007-2009 coresystems GmbH - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* The _PTS method (Prepare To Sleep) is called before the OS is - * entering a sleep state. The sleep state number is passed in Arg0 - */ - -Method(_PTS,1) -{ - // Call a trap so SMI can prepare for Sleep as well. - // TRAP(0x55) -} - -/* The _WAK method is called on system wakeup */ - -Method(_WAK,1) -{ - // CPU specific part - - // Notify PCI Express slots in case a card - // was inserted while a sleep state was active. - - // Are we going to S3? - If (LEqual(Arg0, 3)) { - // .. - } - - // Are we going to S4? - If (LEqual(Arg0, 4)) { - // .. - } - - // TODO: Windows XP SP2 P-State restore - - Return(Package(){0,0}) -} diff --git a/src/mainboard/ibase/mb899/dsdt.asl b/src/mainboard/ibase/mb899/dsdt.asl index 31b67a7..e142624 100644 --- a/src/mainboard/ibase/mb899/dsdt.asl +++ b/src/mainboard/ibase/mb899/dsdt.asl @@ -23,9 +23,6 @@ 0x20090419 // OEM revision ) { - // Some generic macros - #include "acpi/platform.asl" - // global NVS and variables #include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
diff --git a/src/mainboard/intel/d945gclf/acpi/platform.asl b/src/mainboard/intel/d945gclf/acpi/platform.asl deleted file mode 100644 index 21eb3df..0000000 --- a/src/mainboard/intel/d945gclf/acpi/platform.asl +++ /dev/null @@ -1,48 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2007-2009 coresystems GmbH - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* The _PTS method (Prepare To Sleep) is called before the OS is - * entering a sleep state. The sleep state number is passed in Arg0 - */ - -Method(_PTS,1) -{ - // Call a trap so SMI can prepare for Sleep as well. - // TRAP(0x55) -} - -/* The _WAK method is called on system wakeup */ - -Method(_WAK,1) -{ - // CPU specific part - - // Notify PCI Express slots in case a card - // was inserted while a sleep state was active. - - // Are we going to S3? - If (LEqual(Arg0, 3)) { - // .. - } - - // Are we going to S4? - If (LEqual(Arg0, 4)) { - // .. - } - - // TODO: Windows XP SP2 P-State restore - - Return(Package(){0,0}) -} diff --git a/src/mainboard/intel/d945gclf/dsdt.asl b/src/mainboard/intel/d945gclf/dsdt.asl index afc5386..3b594be 100644 --- a/src/mainboard/intel/d945gclf/dsdt.asl +++ b/src/mainboard/intel/d945gclf/dsdt.asl @@ -23,9 +23,6 @@ 0x20090419 // OEM revision ) { - // Some generic macros - #include "acpi/platform.asl" - // global NVS and variables #include <southbridge/intel/i82801gx/acpi/globalnvs.asl> #include <southbridge/intel/common/acpi/platform.asl> diff --git a/src/mainboard/kontron/986lcd-m/acpi/platform.asl b/src/mainboard/kontron/986lcd-m/acpi/platform.asl deleted file mode 100644 index 9866110..0000000 --- a/src/mainboard/kontron/986lcd-m/acpi/platform.asl +++ /dev/null @@ -1,48 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2007-2009 coresystems GmbH - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* The _PTS method (Prepare To Sleep) is called before the OS is - * entering a sleep state. The sleep state number is passed in Arg0 - */ - -Method(_PTS,1) -{ - // Call a trap so SMI can prepare for Sleep as well. - // TRAP(0x55) -} - -/* The _WAK method is called on system wakeup */ - -Method(_WAK,1) -{ - // CPU specific part - - // Notify PCI Express slots in case a card - // was inserted while a sleep state was active. - - // Are we going to S3? - If (LEqual(Arg0, 3)) { - // .. - } - - // Are we going to S4? - If (LEqual(Arg0, 4)) { - // .. - } - - // TODO: Windows XP SP2 P-State restore - - Return(Package(){0,0}) -} diff --git a/src/mainboard/kontron/986lcd-m/dsdt.asl b/src/mainboard/kontron/986lcd-m/dsdt.asl index d4ffd7b..c3d1910 100644 --- a/src/mainboard/kontron/986lcd-m/dsdt.asl +++ b/src/mainboard/kontron/986lcd-m/dsdt.asl @@ -23,9 +23,6 @@ 0x20090419 // OEM revision ) { - // Some generic macros - #include "acpi/platform.asl" - // global NVS and variables #include <southbridge/intel/i82801gx/acpi/globalnvs.asl> #include <southbridge/intel/common/acpi/platform.asl> diff --git a/src/mainboard/roda/rk886ex/acpi/platform.asl b/src/mainboard/roda/rk886ex/acpi/platform.asl deleted file mode 100644 index ebd22af..0000000 --- a/src/mainboard/roda/rk886ex/acpi/platform.asl +++ /dev/null @@ -1,80 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2007-2009 coresystems GmbH - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of - * the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* The _PTS method (Prepare To Sleep) is called before the OS is - * entering a sleep state. The sleep state number is passed in Arg0 - */ - -Method(_PTS,1) -{ - // Call a trap so SMI can prepare for Sleep as well. - // TRAP(0x55) -} - -/* The _WAK method is called on system wakeup */ - -Method(_WAK,1) -{ - // CPU specific part - - // Notify PCI Express slots in case a card - // was inserted while a sleep state was active. - - // Are we going to S3? - If (LEqual(Arg0, 3)) { - // .. - } - - // Are we going to S4? - If (LEqual(Arg0, 4)) { - // .. - } - - // TODO: Windows XP SP2 P-State restore - - Return(Package(){0,0}) -} - -/* System Bus */ - -Scope(_SB) -{ - /* This method is placed on the top level, so we can make sure it's the - * first executed _INI method. - */ - Method(_INI, 0) - { - /* The DTS data in NVS is probably not up to date. - * Update temperature values and make sure AP thermal - * interrupts can happen - */ - - // TRAP(71) // TODO - - \GOS() - - /* And the OS workarounds start right after we know what we're - * running: Windows XP SP1 needs to have C-State coordination - * enabled in SMM. - */ - If (LAnd(LEqual(OSYS, 2001), MPEN)) { - // TRAP(61) // TODO - } - - /* SMM power state and C4-on-C3 settings need to be updated */ - // TRAP(43) // TODO - } -} diff --git a/src/mainboard/roda/rk886ex/dsdt.asl b/src/mainboard/roda/rk886ex/dsdt.asl index f9a2abe..1132ad9 100644 --- a/src/mainboard/roda/rk886ex/dsdt.asl +++ b/src/mainboard/roda/rk886ex/dsdt.asl @@ -24,9 +24,6 @@ 0x20090419 // OEM revision ) { - // Some generic macros - #include "acpi/platform.asl" - // global NVS and variables #include <southbridge/intel/i82801gx/acpi/globalnvs.asl> #include <southbridge/intel/common/acpi/platform.asl>
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36882 )
Change subject: mb/(ich7): Use 'intel/common/acpi/platform.asl' ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36882/1/src/mainboard/apple/macbook... File src/mainboard/apple/macbook21/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/36882/1/src/mainboard/apple/macbook... PS1, Line 43: Scope(_SB) : { : /* This method is placed on the top level, so we can make sure it's the : * first executed _INI method. : */ : Method(_INI, 0) : { : /* The DTS data in NVS is probably not up to date. : * Update temperature values and make sure AP thermal : * interrupts can happen : */ : : // TRAP(71) // TODO : : \GOS() : : /* And the OS workarounds start right after we know what we're : * running: Windows XP SP1 needs to have C-State coordination : * enabled in SMM. : */ : If (LAnd(LEqual(OSYS, 2001), MPEN)) { : // TRAP(61) // TODO : } : : /* SMM power state and C4-on-C3 settings need to be updated */ : // TRAP(43) // TODO : } : } This is not found somewhere else. It's all broken except \GOS() but coreboot barely uses OSYS
Hello Evgeny Zinoviev, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36882
to look at the new patch set (#2).
Change subject: mb/(ich7): Use 'intel/common/acpi/platform.asl' ......................................................................
mb/(ich7): Use 'intel/common/acpi/platform.asl'
Change-Id: I547801efeb91aa2cbe9b4336bf2f3f00b8a8c07c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- D src/mainboard/gigabyte/ga-945gcm-s2l/acpi/platform.asl M src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl D src/mainboard/ibase/mb899/acpi/platform.asl M src/mainboard/ibase/mb899/dsdt.asl D src/mainboard/intel/d945gclf/acpi/platform.asl M src/mainboard/intel/d945gclf/dsdt.asl D src/mainboard/kontron/986lcd-m/acpi/platform.asl M src/mainboard/kontron/986lcd-m/dsdt.asl 8 files changed, 0 insertions(+), 204 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/36882/2
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/36882 )
Change subject: mb/(ich7): Use 'intel/common/acpi/platform.asl' ......................................................................
Abandoned
-
Arthur Heymans (Code Review) -
HAOUAS Elyes (Code Review)