Attention is currently required from: Tarun Tuli, Reka Norman, Tyler Wang, Eric Lai.
Jimmy Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74728 )
Change subject: mb/google/nissa/var/craask: avoid camera LED blinking during boot
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Hi Jimmy, […]
Hi Eric & Tyler,
If you remove D15 in VCM configuration, you will meet some I2C error during opening CCA.
You can check the kernel log to confirm the symptom is the same as mine.
[ 62.653795] dw9714 i2c-PRP0001:01: I2C write fail
[ 62.653804] dw9714 i2c-PRP0001:01: dw9714_vcm_resume I2C failure: -5
The VCM & Sensor driver are different, but they are using the same power rail.
We need to register this power for VCM & Sensor.
Then ACPI power control will count the number of usage.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74728
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78ed5efe1e2c071d817c1e0455271886e89e63c7
Gerrit-Change-Number: 74728
Gerrit-PatchSet: 1
Gerrit-Owner: Jimmy Su
jimmy.su@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Jimmy Su
jimmy.su@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andy Yeh
andy.yeh@intel.com
Gerrit-CC: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-CC: Tian Shu Qiu
tian.shu.qiu@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 27 Apr 2023 03:39:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment