Attention is currently required from: Henry Sun, Chen Wisley, Wisley Chen.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58562 )
Change subject: mb/google/dedede/var/haboki: Generate new SPD ID for new memory parts
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58562/comment/1bfe59d8_89fd8158
PS5, Line 11: T
This line can be removed.
https://review.coreboot.org/c/coreboot/+/58562/comment/768e8b84_9a276843
PS5, Line 12: MT53E512M32D1NP-046 WT:B
: H54G46CYRBX267
: K4U6E3S4AB-MGCL
Please add the manufacturers.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58562
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf2f7352a4bd6a58e3e7abdcaac823b863984732
Gerrit-Change-Number: 58562
Gerrit-PatchSet: 5
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Attention: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 25 Oct 2021 19:39:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment