Change in ...coreboot[master]: spd_bin: Do not depend CONFIG_DIMM_MAX on CONFIG_GENERIC_SPD_BIN

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Julius Werner (Code Review)

2 May 2019 2 May '19

9:41 p.m.

Julius Werner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32548

Change subject: spd_bin: Do not depend CONFIG_DIMM_MAX on CONFIG_GENERIC_SPD_BIN ......................................................................

spd_bin: Do not depend CONFIG_DIMM_MAX on CONFIG_GENERIC_SPD_BIN

I can't claim that I really understand what this code does, but it looks like there are platforms that use code from lib/spd_bin.c without enabling CONFIG_GENERIC_SPD_BIN. Some functions in that file contain references to CONFIG_DIMM_MAX, so that option probably shouldn't depend on CONFIG_GENERIC_SPD_BIN.

Change-Id: I041c52b6bd255e9a9920e5a101165ba5fc5fa6f3 Signed-off-by: Julius Werner jwerner@chromium.org --- M src/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/32548/1

diff --git a/src/Kconfig b/src/Kconfig index 90c724e..e2088e8d 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -1155,7 +1155,6 @@ config DIMM_MAX int default 4 - depends on GENERIC_SPD_BIN help Total number of memory DIMM slots available on motherboard. It is multiplication of number of channel to number of DIMMs per

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Furquan Shaikh (Code Review)

3 May 3 May

5:34 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32548 )

Change subject: spd_bin: Do not depend CONFIG_DIMM_MAX on CONFIG_GENERIC_SPD_BIN ......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/32548/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32548/2//COMMIT_MSG@10 PS2, Line 10: platforms that use code from lib/spd_bin.c without : enabling CONFIG_GENERIC_SPD_BIN Probably it should have been part of this change: https://review.coreboot.org/c/coreboot/+/18265/4/src/lib/Makefile.inc

-- To view, visit https://review.coreboot.org/c/coreboot/+/32548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I041c52b6bd255e9a9920e5a101165ba5fc5fa6f3 Gerrit-Change-Number: 32548 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 03 May 2019 15:34:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

6 May 6 May

12:31 p.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32548 )

Change subject: spd_bin: Do not depend CONFIG_DIMM_MAX on CONFIG_GENERIC_SPD_BIN ......................................................................

spd_bin: Do not depend CONFIG_DIMM_MAX on CONFIG_GENERIC_SPD_BIN

Change-Id: I041c52b6bd255e9a9920e5a101165ba5fc5fa6f3 Signed-off-by: Julius Werner jwerner@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/32548 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

diff --git a/src/Kconfig b/src/Kconfig index 05875b6..b4898bd 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -1153,7 +1153,6 @@ config DIMM_MAX int default 4 - depends on GENERIC_SPD_BIN help Total number of memory DIMM slots available on motherboard. It is multiplication of number of channel to number of DIMMs per

-- To view, visit https://review.coreboot.org/c/coreboot/+/32548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I041c52b6bd255e9a9920e5a101165ba5fc5fa6f3 Gerrit-Change-Number: 32548 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

mikeb mikeb (Code Review)

19 May 19 May

10 a.m.

mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32548 )

Change subject: spd_bin: Do not depend CONFIG_DIMM_MAX on CONFIG_GENERIC_SPD_BIN ......................................................................

Patch Set 3:

After this commit has been merged, other - even very different boards - are now getting CONFIG_DIMM_MAX=4 added to their .config . Is this expected behaviour?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I041c52b6bd255e9a9920e5a101165ba5fc5fa6f3 Gerrit-Change-Number: 32548 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: mikeb mikeb mikebdp2@gmail.com Gerrit-Comment-Date: Sun, 19 May 2019 08:00:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mike Banon (Code Review)

10:06 a.m.

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32548 )

Change subject: spd_bin: Do not depend CONFIG_DIMM_MAX on CONFIG_GENERIC_SPD_BIN ......................................................................

Patch Set 3:

Perhaps this CONFIG_DIMM_MAX should be more board-specific, otherwise it could affect e.g. ASUS KGPE-D16 which has more than 4 DIMM slots

-- To view, visit https://review.coreboot.org/c/coreboot/+/32548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I041c52b6bd255e9a9920e5a101165ba5fc5fa6f3 Gerrit-Change-Number: 32548 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mike Banon mikebdp2@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 19 May 2019 08:06:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

11:10 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32548 )

Change subject: spd_bin: Do not depend CONFIG_DIMM_MAX on CONFIG_GENERIC_SPD_BIN ......................................................................

Patch Set 3:

...

Perhaps this CONFIG_DIMM_MAX should be more board-specific, otherwise it could affect e.g. ASUS KGPE-D16 which has more than 4 DIMM slots

please see https://review.coreboot.org/#/c/coreboot/+/32882/

-- To view, visit https://review.coreboot.org/c/coreboot/+/32548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I041c52b6bd255e9a9920e5a101165ba5fc5fa6f3 Gerrit-Change-Number: 32548 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Mike Banon mikebdp2@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 19 May 2019 09:10:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

12:06 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32548 )

Change subject: spd_bin: Do not depend CONFIG_DIMM_MAX on CONFIG_GENERIC_SPD_BIN ......................................................................

Patch Set 3:

...

...
Perhaps this CONFIG_DIMM_MAX should be more board-specific, otherwise it could affect e.g. ASUS KGPE-D16 which has more than

4

...
DIMM slots

please see https://review.coreboot.org/#/c/coreboot/+/32882/

https://review.coreboot.org/#/c/coreboot/+/32883/ better solution

-- To view, visit https://review.coreboot.org/c/coreboot/+/32548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I041c52b6bd255e9a9920e5a101165ba5fc5fa6f3 Gerrit-Change-Number: 32548 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Mike Banon mikebdp2@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 19 May 2019 10:06:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2176

days inactive

2193

days old

coreboot-gerrit@coreboot.org

6 comments

6 participants

tags (0)

participants (6)

Furquan Shaikh (Code Review)
HAOUAS Elyes (Code Review)
Julius Werner (Code Review)
Mike Banon (Code Review)
mikeb mikeb (Code Review)
Patrick Georgi (Code Review)