Change in coreboot[master]: intelblocks: Add function to enable GPE - coreboot-gerrit

6 May 2022


      Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Eric Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64089 )
Change subject: intelblocks: Add function to enable GPE
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Patchset:
PS1: 
Thanks Maulik for fixing this in proper.
File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/c/coreboot/+/64089/comment/2d7dc8c1_6acfde1a 
PS1, Line 173:                                
tabs ?
https://review.coreboot.org/c/coreboot/+/64089/comment/702382bb_5d17b58c 
PS1, Line 193: if(
if (
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/64089
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27e525f50c374c2cc9675e77eaa7774683a6e7c2
Gerrit-Change-Number: 64089
Gerrit-PatchSet: 1
Gerrit-Owner: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Fri, 06 May 2022 06:51:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment