Maulik V Vaghela has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48231 )
Change subject: mb/google/dedede: Configure Acoustic noise mitigation UPDs ......................................................................
mb/google/dedede: Configure Acoustic noise mitigation UPDs
Enable Acoustic noise mitigation for drawcia and set slew rate to 1/4 which is calibrated value for board. Other values like PreWake, Rampup and RampDown are 0 bydefault.
BUG=b:162192346 BRANCH=dedede TEST=Correct value is passed to UPD and Acoustic noise test passes.
Change-Id: Iadcf332d59dac2ba191b82742a18a1ab326940d1 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/48231/1
diff --git a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb index dcb46cc..3e88170 100644 --- a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb +++ b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb @@ -66,6 +66,10 @@ register "ImonOffset" = "1400" # Imon Offset = 1.4 register "ImonSlope" = "100" # Imon Slope = 1.0
+ # Enable Acoustic noise mitigation and set slew rate to 1/4 + register "AcousticNoiseMitigation" = "1" + register "SlowSlewRate" = "1" + device domain 0 on device pci 05.0 on # IPU - MIPI Camera chip drivers/intel/mipi_camera
Hello build bot (Jenkins), Chen Wisley, Ronak Kanabar, Aamir Bohra, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48231
to look at the new patch set (#5).
Change subject: mb/google/dedede: Configure Acoustic noise mitigation UPDs ......................................................................
mb/google/dedede: Configure Acoustic noise mitigation UPDs
Enable Acoustic noise mitigation for drawcia and set slew rate to 1/4 which is calibrated value for the board. Other values like PreWake, Rampup and RampDown are 0 by default.
BUG=b:162192346 BRANCH=dedede TEST=Correct value is passed to UPD and Acoustic noise test passes.
Change-Id: Iadcf332d59dac2ba191b82742a18a1ab326940d1 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/48231/5
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48231 )
Change subject: mb/google/dedede: Configure Acoustic noise mitigation UPDs ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48231/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48231/5//COMMIT_MSG@7 PS5, Line 7: mb/google/dedede: Configure Acoustic noise mitigation UPDs Nit: mb/google/dedede/var/drawcia:
Patrick Georgi has uploaded a new patch set (#6) to the change originally created by Maulik V Vaghela. ( https://review.coreboot.org/c/coreboot/+/48231 )
Change subject: mb/google/dedede/var/drawcia: Configure Acoustic noise mitigation UPDs ......................................................................
mb/google/dedede/var/drawcia: Configure Acoustic noise mitigation UPDs
Enable Acoustic noise mitigation for drawcia and set slew rate to 1/4 which is calibrated value for the board. Other values like PreWake, Rampup and RampDown are 0 by default.
BUG=b:162192346 BRANCH=dedede TEST=Correct value is passed to UPD and Acoustic noise test passes.
Change-Id: Iadcf332d59dac2ba191b82742a18a1ab326940d1 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/48231/6
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48231 )
Change subject: mb/google/dedede/var/drawcia: Configure Acoustic noise mitigation UPDs ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48231/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48231/5//COMMIT_MSG@7 PS5, Line 7: mb/google/dedede: Configure Acoustic noise mitigation UPDs
Nit: mb/google/dedede/var/drawcia:
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48231 )
Change subject: mb/google/dedede/var/drawcia: Configure Acoustic noise mitigation UPDs ......................................................................
mb/google/dedede/var/drawcia: Configure Acoustic noise mitigation UPDs
Enable Acoustic noise mitigation for drawcia and set slew rate to 1/4 which is calibrated value for the board. Other values like PreWake, Rampup and RampDown are 0 by default.
BUG=b:162192346 BRANCH=dedede TEST=Correct value is passed to UPD and Acoustic noise test passes.
Change-Id: Iadcf332d59dac2ba191b82742a18a1ab326940d1 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48231 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb index dcb46cc..493854c 100644 --- a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb +++ b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb @@ -66,6 +66,11 @@ register "ImonOffset" = "1400" # Imon Offset = 1.4 register "ImonSlope" = "100" # Imon Slope = 1.0
+ # Enable Acoustic noise mitigation and set slew rate to 1/4 + # Rest of the parameters are 0 by default. + register "AcousticNoiseMitigation" = "1" + register "SlowSlewRate" = "1" + device domain 0 on device pci 05.0 on # IPU - MIPI Camera chip drivers/intel/mipi_camera
-
Karthik Ramasubramanian (Code Review) -
Maulik V Vaghela (Code Review)
-
Patrick Georgi (Code Review)