Attention is currently required from: Marx Wang, Rizwan Qureshi, Sridhar Siricilla, Krishna P Bhat D, Balaji Manigandan, Nick Vaccaro, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59685 )
Change subject: soc/intel/common Add support for CSE IOM/NPHY sub-parition update ......................................................................
Patch Set 11:
(10 comments)
File src/soc/intel/common/block/cse/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/59685/comment/b9888182_1b7af40e PS11, Line 110: I think we should hash the IOM and NPHY binaries as well, just like we do for cse_rw
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/59685/comment/df374003_506283f8 PS11, Line 15: #define BPDT_HEADER_SZ sizeof(struct bpdt_header) : #define BPDT_ENTRY_SZ sizeof(struct bpdt_entry) : #define SUBPART_HEADER_SZ sizeof(struct subpart_hdr) : #define SUBPART_ENTRY_SZ sizeof(struct subpart_entry) : #define SUBPART_MANIFEST_HDR_SZ sizeof(struct subpart_entry_manifest_header) line up the right sides please
https://review.coreboot.org/c/coreboot/+/59685/comment/8cf56d26_2bdc973a PS11, Line 768: nit: remove the extra space
https://review.coreboot.org/c/coreboot/+/59685/comment/52f573a6_041ae94a PS11, Line 810: nit: extra line
https://review.coreboot.org/c/coreboot/+/59685/comment/ee7cba3a_be3f87be PS11, Line 888: cbfs_locate_file_in_region should now be `cbfs_locate_file_in_region`
https://review.coreboot.org/c/coreboot/+/59685/comment/8c3755f8_4a1412c0 PS11, Line 958: /* Get sub-partition blob's version */ Should these blobs have a hash stored in FW_MAIN_A/FW_MAIN_B/COREBOOT, just like the me_rw hash (and then verified here) ?
https://review.coreboot.org/c/coreboot/+/59685/comment/f10ae237_52421d88 PS11, Line 975: int `size_t`
https://review.coreboot.org/c/coreboot/+/59685/comment/2d557cac_bbd204de PS11, Line 975: 2 `ARRAY_SIZE(cse_regions)`
https://review.coreboot.org/c/coreboot/+/59685/comment/209b126d_c96dad15 PS11, Line 976: nit: extra line
https://review.coreboot.org/c/coreboot/+/59685/comment/7ad2b86c_39b65cc3 PS11, Line 1035: void cse_fw_sync(void) Since the mainboard is the entity with the knowledge of whether or not an update is ultimately required, I think it might be helpful to have the mainboard pass in e.g., a bitmask representing the components to potentially update.
e.g., keep a list of updateable partitions:
``` enum cse_updateable_sub_part { CSE_SUB_PART_IOM = 1 << 0, CSE_SUB_PART_NPHY = 1 << 1, }; ```
and then cse_fw_sync() takes in this bitmask. This should also make `is_cse_sub_part_update_req` unnecessary.