Attention is currently required from: Lean Sheng Tan, Nick Vaccaro, Subrata Banik, Werner Zeh.
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78825?usp=email )
Change subject: soc/intel/*: Correct ACPI device name for eMMC ......................................................................
soc/intel/*: Correct ACPI device name for eMMC
The ACPI name of any device needs to match the name used for generating the S0i3 LPI constraint list, which comes from soc_acpi_name() for each SoC. The names used for the eMMC controller do not match, which will lead to broken ACPI tables since the LPI constriant will reference an ACPI device which does not exist. Some OSes tolerate this better than others, but it should still be corrected.
TEST=build/boot google/{hatch,volteer, brya}, dump ACPI and verify no invalid device names referenced.
Change-Id: Icbc22b6b2a84bbe73f1b09083f27081612db5eba Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/soc/intel/alderlake/acpi/scs.asl M src/soc/intel/braswell/acpi/scc.asl M src/soc/intel/cannonlake/acpi/scs.asl M src/soc/intel/elkhartlake/acpi/scs.asl M src/soc/intel/jasperlake/acpi/scs.asl 5 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/78825/1
diff --git a/src/soc/intel/alderlake/acpi/scs.asl b/src/soc/intel/alderlake/acpi/scs.asl index aac78e8..d39c66d 100644 --- a/src/soc/intel/alderlake/acpi/scs.asl +++ b/src/soc/intel/alderlake/acpi/scs.asl @@ -18,7 +18,7 @@ }
/* EMMC */ - Device(PEMC) { + Device(EMMC) { Name(_ADR, 0x001A0000) Name (_DDN, "eMMC Controller") Name(TEMP, 0) diff --git a/src/soc/intel/braswell/acpi/scc.asl b/src/soc/intel/braswell/acpi/scc.asl index 5efe5a0..469e7d2 100644 --- a/src/soc/intel/braswell/acpi/scc.asl +++ b/src/soc/intel/braswell/acpi/scc.asl @@ -63,7 +63,7 @@ } }
-Device (PEMC) +Device (EMMC) { Name (_ADR, 0x00100000)
diff --git a/src/soc/intel/cannonlake/acpi/scs.asl b/src/soc/intel/cannonlake/acpi/scs.asl index 7def761..fcadcbd 100644 --- a/src/soc/intel/cannonlake/acpi/scs.asl +++ b/src/soc/intel/cannonlake/acpi/scs.asl @@ -15,7 +15,7 @@ }
/* EMMC */ - Device(PEMC) { + Device(EMMC) { Name(_ADR, 0x001A0000) Name (_DDN, "eMMC Controller") Name (TEMP, 0) diff --git a/src/soc/intel/elkhartlake/acpi/scs.asl b/src/soc/intel/elkhartlake/acpi/scs.asl index c6d71c1..3955402 100644 --- a/src/soc/intel/elkhartlake/acpi/scs.asl +++ b/src/soc/intel/elkhartlake/acpi/scs.asl @@ -15,7 +15,7 @@ }
/* EMMC */ - Device(PEMC) { + Device(EMMC) { Name(_ADR, 0x001A0000) Name (_DDN, "eMMC Controller") Name (TEMP, 0) diff --git a/src/soc/intel/jasperlake/acpi/scs.asl b/src/soc/intel/jasperlake/acpi/scs.asl index b58608f..491df51 100644 --- a/src/soc/intel/jasperlake/acpi/scs.asl +++ b/src/soc/intel/jasperlake/acpi/scs.asl @@ -15,7 +15,7 @@ }
/* EMMC */ - Device(PEMC) { + Device(EMMC) { Name(_ADR, 0x001A0000) Name (_DDN, "eMMC Controller") Name (TEMP, 0)