Attention is currently required from: Stephen Boyd, Subrata Banik, Yu-Ping Wu.
Julius Werner has posted comments on this change by Julius Werner. ( https://review.coreboot.org/c/coreboot/+/86142?usp=email )
Change subject: libpayload: Unify selfboot() implementations
......................................................................
Patch Set 1:
(1 comment)
File payloads/libpayload/libc/selfboot.c:
https://review.coreboot.org/c/coreboot/+/86142/comment/fbba02a0_e8231ae9?usp... :
PS1, Line 35: __attribute__((__regparm__(0)))
I think technically this doesn't really do anything, because our default calling convention is already `regparm(0)` to begin with. But coreboot also still does it when loading the payload, so I guess it's more consistent to do it here too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86142?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If14040e38d968b5eea31cd6cd25efb1845a7b081
Gerrit-Change-Number: 86142
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Stephen Boyd
swboyd@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Stephen Boyd
swboyd@chromium.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 24 Jan 2025 00:59:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No