Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58093 )
Change subject: soc/intel/common: Implement __weak smihandler_soc_disable_busmaster
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
hi Tim, […]
Thanks for always looking out for opportunities for improvement Kane, it is appreciated! You're right that it does still access the PMC I/O space, I am just wondering where the requirement for BME (which is supposed to be for DMA) comes from. coreboot's strategy is to use BME as little as possible; there are very few devices that require it to be set while coreboot is running.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58093
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ed7e6a3f60588bfb90481ea493495080dbbfd58
Gerrit-Change-Number: 58093
Gerrit-PatchSet: 2
Gerrit-Owner: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 06 Oct 2021 19:06:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kane Chen
kane.chen@intel.corp-partner.google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment