Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Sukumar Ghorai.
Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72723 )
Change subject: [WIP] soc/intel/meteorlake: Enable Trace Hub
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File src/soc/intel/meteorlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/72723/comment/8a9fe037_df9139ba
PS1, Line 278: m_cfg->PlatformDebugOption = 2;
fixed value not recommended, add #define […]
This is WIP patch. Added to make sure previous patches get built with the config set in this patch. We intend to keep NPK/Trace hub disabled only for production. I dont plan to get this patch merged. When entire series of patches are ready, i will remove WIP from relavent patches and then folks can review the patches.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72723
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I335b15788fefb83f9f62560b160d1e84494b262a
Gerrit-Change-Number: 72723
Gerrit-PatchSet: 1
Gerrit-Owner: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Comment-Date: Thu, 02 Feb 2023 16:50:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-MessageType: comment