Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 )
Change subject: payloads/cbui: Add new payload CBUI ......................................................................
Patch Set 50:
(34 comments)
File payloads/cbui/NuklearUI/NuklearDatePicker.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/601d7562_aba963f3 PS50, Line 36: case 6: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/b4622bf4_e6f7f86b PS50, Line 37: case 9: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
File payloads/cbui/NuklearUI/NuklearRW.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/54f0512c_7fab9a65 PS50, Line 289: static const char *titles[] = { "Hex-View", "Header", "Index/Data" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/6776183e_6192ca62 PS50, Line 323: static const char *entries[] = { "NVRAM" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAcpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/a5ab9533_fd1ce48c PS50, Line 40: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/3af63fb7_90eec681 PS50, Line 43: static const char *tabs[] = { "RSDP", "XSDT", "RSDT", "FACP", "HPET", "APIC", "MCFG", static const char * array should probably be static const char * const
File payloads/cbui/arch/x86/int32.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/f51eade3_431cbe59 PS50, Line 20: typedef struct __attribute__ ((packed)) { Prefer __packed over __attribute__((packed))
File payloads/cbui/arch/x86/int32.nasm:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/c700bd54_f674cd47 PS50, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'?
File payloads/cbui/gfx/vbe.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/19d38c6c_6ffaf419 PS50, Line 24: static u8 low_mem[0x1000] __attribute__ ((section(".lowmem"))); Prefer __section(".lowmem") over __attribute__((section(".lowmem")))
File payloads/cbui/lang/de.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/481e0577_aa973c8e PS50, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/b483b052_33be2128 PS50, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/4e6754ff_dd8c31d1 PS50, Line 47: "Kein Platz auf dem Heap.\nBitte vergroBere den" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/20d25c8c_ec0a1e49 PS50, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/0026a732_b61a6cfb PS50, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/764ae940_40273f69 PS50, Line 65: "Fehler: Keine CMOS Eintrage gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/330eb6a4_53f1553e PS50, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/e194d9c5_f9604867 PS50, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations
File payloads/cbui/lang/en.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/9538ae1e_cb561b68 PS50, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/c3bf4a17_e17f92ec PS50, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/d457cfb7_a80ea193 PS50, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/c5dbb574_513bbb01 PS50, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/a27988dd_9cdd0293 PS50, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations
File payloads/cbui/modules/bootlog_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/b28059ee_07f7633e PS50, Line 28: } __attribute__ ((__packed__)); Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/059b2307_32fdd59f PS50, Line 82: } void function return statements are not generally useful
File payloads/cbui/modules/cbfs_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/1a2c5e8d_e21620b5 PS50, Line 50: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/54877575_a9a899fa PS50, Line 59: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
File payloads/cbui/modules/cpuinfo_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/4b772c9b_dc033b05 PS50, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/4990f344_b61fabd8 PS50, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/ec48252f_795e241c PS50, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/40212da7_3be30ebf PS50, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/1f8c12b8_24163baa PS50, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/06f2fe75_73b151a7 PS50, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/435670e6_9df3658e PS50, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159844): https://review.coreboot.org/c/coreboot/+/23586/comment/3ba7c246_76f35a96 PS50, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
-
build bot (Jenkins) (Code Review)