Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37887 )
Change subject: soc/intel/tglrvp: Add ACPI support for CNVi ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37887/8/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/cnvi.asl:
https://review.coreboot.org/c/coreboot/+/37887/8/src/soc/intel/tigerlake/acp... PS8, Line 115: Store (GPP_VGPIO0, Local0) Please make this patch dependent on "https://review.coreboot.org/c/coreboot/+/38440/15/src/soc/intel/tigerlake/in..." . I chnaged the VGPIO to native function names. So this should be CNV_BTEN.
https://review.coreboot.org/c/coreboot/+/37887/8/src/soc/intel/tigerlake/acp... PS8, Line 132: Store (GPP_VGPIO0, Local0) Ditto as above.
-
Shaunak Saha (Code Review)