Nico Huber has posted comments on this change. ( https://review.coreboot.org/29307 )
Change subject: src: Remove unneeded include <arch/io.h> ......................................................................
Patch Set 13:
I'm getting some errors. some of them looks "odd" to me:
Looks like the errors to expect when an #include is missing. How did you detect which files don't require the #include?
Some of the errors look like they are actually about missing #includes in other places that were hidden because of #includes you remove here.
it was my mistake ... if I remove an "include io.h" for exmple from "src/southbridge/amd/cs5536/cs5536.c", the compiler will complain about unknown type here : "cpu/amd/vr.h"
That's not your mistake then. It means `cpu/amd/vr.h` is missing an #include (it just wasn't visible before).
The same can happen if you remove #includes and just test if it compiles (some other included file can hide the problem). That's why I ask again: How do you decide which #include statements are unneeded? Did you use some static analysis tool? did you read all the code?
-
Nico Huber (Code Review)