Attention is currently required from: Philipp Hug, ron minnich.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/81082?usp=email )
Change subject: Add weak function for SMP hart count ......................................................................
Patch Set 2:
(3 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/81082/comment/e590508e_59731f5d?usp... : PS1, Line 8: needs updating
File src/arch/riscv/smp.c:
https://review.coreboot.org/c/coreboot/+/81082/comment/1f3845d0_2a36b8d3?usp... : PS1, Line 49: * use a poor mans timeout to not wait indefinitiely
this might be too early, the hart_count could e.g. […]
Counting the cpu nodes in FDT this early works (at least for QEMU), but I get your point about troubleshooting. You mean we should just simply stop (wfi) all harts in `smp_pause`? I cooked something up in the latest patchset that moves most of this stuff to `smp_resume`. Let me know what you think.
File src/arch/riscv/smp.c:
https://review.coreboot.org/c/coreboot/+/81082/comment/35d39bbc_e3eafc3a?usp... : PS2, Line 56: //TODO not sure if we need a timeout here or if the time waiting for smp_resume to be called is enough of a timeout take care of that.
-
Maximilian Brune (Code Review)