Attention is currently required from: Cliff Huang, Tim Wawrzynczak, Bernardo Perez Priego.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55989 )
Change subject: cbfstool: Add helper function `buffer_from_file_aligned_size`
......................................................................
Patch Set 5:
(1 comment)
File util/cbfstool/common.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129902):
https://review.coreboot.org/c/coreboot/+/55989/comment/3381b537_62eb65f8
PS5, Line 78: if (buffer->size > (size_t)file_size) {
braces {} are not necessary for single statement blocks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55989
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad3430d476abcdad850505ac50e36cd5d5deecb4
Gerrit-Change-Number: 55989
Gerrit-PatchSet: 5
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Comment-Date: Wed, 06 Oct 2021 17:31:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment