Jarried Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86341?usp=email )
Change subject: soc/mediatek/mt8196: Set the driving strength of SPMI-P to maximum ......................................................................
soc/mediatek/mt8196: Set the driving strength of SPMI-P to maximum
To fix the SPMI-P glitch, the driving strength of SPMI-P needs to be set to maximum. Additionally, a hardware solution is also required.
TEST=Build pass and boot ok BUG=b:383634290
Signed-off-by: Lu Tang lu.tang@mediatek.corp-partner.google.com Change-Id: I131fd04c0313c7ed64bbd123f61d9a6849c8def4 --- M src/soc/mediatek/mt8196/pmif_spmi.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/86341/1
diff --git a/src/soc/mediatek/mt8196/pmif_spmi.c b/src/soc/mediatek/mt8196/pmif_spmi.c index c4a984f..bec3374 100644 --- a/src/soc/mediatek/mt8196/pmif_spmi.c +++ b/src/soc/mediatek/mt8196/pmif_spmi.c @@ -166,8 +166,8 @@ gpio_set_driving(GPIO(SPMI_M_SCL), GPIO_DRV_10_MA); gpio_set_driving(GPIO(SPMI_M_SDA), GPIO_DRV_10_MA); /* SPMI_P 14mA */ - gpio_set_driving(GPIO(SPMI_P_SCL), GPIO_DRV_14_MA); - gpio_set_driving(GPIO(SPMI_P_SDA), GPIO_DRV_14_MA); + gpio_set_driving(GPIO(SPMI_P_SCL), GPIO_DRV_16_MA); + gpio_set_driving(GPIO(SPMI_P_SDA), GPIO_DRV_16_MA); /* SPMI-P set Pull-Down mode */ gpio_set_pull(GPIO(SPMI_P_SCL), GPIO_PULL_ENABLE, GPIO_PULL_DOWN); gpio_set_pull(GPIO(SPMI_P_SDA), GPIO_PULL_ENABLE, GPIO_PULL_DOWN);