[S] Change in coreboot[master]: mb/hp/z220_series: Reorder Kconfig selects alphabetically - coreboot-gerrit

16 Feb 2023


      Attention is currently required from: Felix Singer, Nico Huber, Martin L Roth.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73036 )
Change subject: mb/hp/z220_series: Reorder Kconfig selects alphabetically
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2: 
We probably need a kind of "convention" for Kconfig symbols names such that the alphabetical and semantic ordering is not very different.
Here we have "MEMORY_MAPPED_TPM" and "MAINBOARD_HAS_TPM1"
we also have : "HAVE_" and "_HAS_" .... this makes the alphabetical and semantic very different.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/73036
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4035fabd46b1ba7fa5463abb7f780aeccd6a96e0
Gerrit-Change-Number: 73036
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Comment-Date: Thu, 16 Feb 2023 17:21:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment