build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28024 )
Change subject: mainboard/opencellular/elgon: Add mainboard support ......................................................................
Patch Set 11:
(25 comments)
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... File src/mainboard/opencellular/elgon/gbcv2.dts:
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 215: reg = <0x8440 0xa0000 0x0 0x1000 0x8440 0xb0000 0x0 0x1000>; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 223: interrupts = <0x0 0x44 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4>; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 238: ranges = <0x3000000 0x8010 0x0 0x8010 0x0 0x80 0x0 0x3000000 0x8100 0x0 0x8100 0x0 0x80 0x0 0x3000000 0x8680 0x0 0x8680 0x0 0x160 0x28000000 0x3000000 0x87e0 0x2c000000 0x87e0 0x2c000000 0x0 0x94000000 0x3000000 0x8400 0x0 0x8400 0x0 0x10 0x0 0x3000000 0x8430 0x0 0x8430 0x0 0x2 0x0 0x3000000 0x87e0 0xc6000000 0x87e0 0xc6000000 0x1f 0x3a000000>; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 243: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 246: ranges = <0x3000000 0x87e0 0x0 0x3000000 0x87e0 0x0 0x10 0x0>; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 251: compatible = "cavium,thunder-8890-mdio-nexus"; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 255: assigned-addresses = <0x3000000 0x87e0 0x5000000 0x0 0x800000>; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 256: ranges = <0x87e0 0x5000000 0x3000000 0x87e0 0x5000000 0x0 0x800000>; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 259: compatible = "cavium,thunder-8890-mdio"; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 262: reg = <0x87e0 0x5003800 0x0 0x30>; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 266: compatible = "cavium,thunder-8890-mdio"; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 269: reg = <0x87e0 0x5003880 0x0 0x30>; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 332: compatible = "infineon,slb9645tt"; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 345: local-mac-address = [00 00 00 00 00 00]; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 358: local-mac-address = [00 00 00 00 00 00]; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 379: compatible = "winbond,w25q128", "jedec,spi-nor"; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 415: reg = <0x8800 0x1f000000 0x0 0x39000000 0x87e0 0xc0000000 0x0 0x1000000>; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 416: ranges = <0x1000000 0x0 0x0 0x8830 0x0 0x0 0x10000 0x3000000 0x0 0x10000000 0x8810 0x10000000 0xf 0xf0000000 0x43000000 0x10 0x0 0x8820 0x0 0x10 0x0 0x3000000 0x87e0 0xc0000000 0x87e0 0xc0000000 0x0 0x1000000>; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 419: interrupt-map = <0x0 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x10 0x4 0x0 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x11 0x4 0x0 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x12 0x4 0x0 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x13 0x4>; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 434: reg = <0x8840 0x57000000 0x0 0x39000000 0x87e0 0xc1000000 0x0 0x1000000>; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 435: ranges = <0x1000000 0x0 0x10000 0x8870 0x10000 0x0 0x10000 0x3000000 0x0 0x10000000 0x8850 0x10000000 0xf 0xf0000000 0x43000000 0x10 0x0 0x8860 0x0 0x10 0x0 0x3000000 0x87e0 0xc1000000 0x87e0 0xc1000000 0x0 0x1000000>; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 438: interrupt-map = <0x0 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x14 0x4 0x0 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x15 0x4 0x0 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x16 0x4 0x0 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x17 0x4>; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 453: reg = <0x8880 0x8f000000 0x0 0x39000000 0x87e0 0xc2000000 0x0 0x1000000>; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 454: ranges = <0x1000000 0x0 0x20000 0x88b0 0x20000 0x0 0x10000 0x3000000 0x0 0x10000000 0x8890 0x10000000 0xf 0xf0000000 0x43000000 0x10 0x0 0x88a0 0x0 0x10 0x0 0x3000000 0x87e0 0xc2000000 0x87e0 0xc2000000 0x0 0x1000000>; line over 80 characters
https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/gb... PS11, Line 457: interrupt-map = <0x0 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x18 0x4 0x0 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x19 0x4 0x0 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x1a 0x4 0x0 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x1b 0x4>; line over 80 characters