Change in coreboot[master]: cpu/x86/smm: Make BIOS all upper case

[Name of user not set (Code Review)]

[e-mail] has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38854 )

Change subject: cpu/x86/smm: Make BIOS all upper case
......................................................................

cpu/x86/smm: Make BIOS all upper case

In an CL:38821 a reviewer noted that BIOS is upper case.  This
patch fixes that.

Signed-off-by: Eugene D. Myers 
Change-Id: I85d78b5e08a7643c3d87e3daf353d6b3ba8d306b
---
M src/cpu/x86/smm/smm_module_loader.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/38854/1

diff --git a/src/cpu/x86/smm/smm_module_loader.c b/src/cpu/x86/smm/smm_module_loader.c
index 66a40c4..856ca78 100644
--- a/src/cpu/x86/smm/smm_module_loader.c
+++ b/src/cpu/x86/smm/smm_module_loader.c
@@ -396,7 +396,7 @@
    /* Does the required amount of memory exceed the SMRAM region size? */
    total_size = total_stack_size + handler_size;
    total_size += fxsave_size + SMM_DEFAULT_SIZE;
-	// account for the bios resource list
+	/* Account for the BIOS resource list */
    if (CONFIG(STM))
    	total_size += CONFIG_BIOS_RESOURCE_LIST_SIZE;

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38854 )

Change subject: cpu/x86/smm: Make BIOS all upper case
......................................................................

Patch Set 3: Code-Review+1

Change in coreboot[master]: cpu/x86/smm: Convert C++ style comment

[Name of user not set (Code Review)]

Hello Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38854

to look at the new patch set (#5).

Change subject: cpu/x86/smm: Convert C++ style comment
......................................................................

cpu/x86/smm: Convert C++ style comment

Originally, this patch made 'BIOS' uppercase in the referenced comment
and converted the C++ style to be consistent with the remainder of
the function.  Somewhere, the BIOS because uppercase creating a merge
conflict.

Now this CL converts the C++ style to be consistent with the remainder
of the comments.

Signed-off-by: Eugene D. Myers 
Change-Id: I85d78b5e08a7643c3d87e3daf353d6b3ba8d306b
---
M src/cpu/x86/smm/smm_module_loader.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/38854/5

Change in coreboot[master]: cpu/x86/smm: Convert C++ style comment

[Name of user not set (Code Review)]

Hello Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38854

to look at the new patch set (#6).

Change subject: cpu/x86/smm: Convert C++ style comment
......................................................................

cpu/x86/smm: Convert C++ style comment

Originally, this patch made 'BIOS' uppercase in the referenced comment
and converted the C++ style to be consistent with the remainder of
the function.  Somewhere, the 'BIOS' became uppercase creating a merge
conflict.

Now this CL converts the C++ style to be consistent with the remainder
of the comments.

Signed-off-by: Eugene D. Myers 
Change-Id: I85d78b5e08a7643c3d87e3daf353d6b3ba8d306b
---
M src/cpu/x86/smm/smm_module_loader.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/38854/6

Change in coreboot[master]: cpu/x86/smm: Convert C++ style comment

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38854 )

Change subject: cpu/x86/smm: Convert C++ style comment
......................................................................

Patch Set 7: Code-Review+2

Change in coreboot[master]: cpu/x86/smm: Convert C++ style comment

[Nico Huber (Code Review)]

Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38854 )

Change subject: cpu/x86/smm: Convert C++ style comment
......................................................................

cpu/x86/smm: Convert C++ style comment

Originally, this patch made 'BIOS' uppercase in the referenced comment
and converted the C++ style to be consistent with the remainder of
the function.  Somewhere, the 'BIOS' became uppercase creating a merge
conflict.

Now this CL converts the C++ style to be consistent with the remainder
of the comments.

Signed-off-by: Eugene D. Myers 
Change-Id: I85d78b5e08a7643c3d87e3daf353d6b3ba8d306b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38854
Reviewed-by: HAOUAS Elyes 
Tested-by: build bot (Jenkins) 
---
M src/cpu/x86/smm/smm_module_loader.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  HAOUAS Elyes: Looks good to me, approved

diff --git a/src/cpu/x86/smm/smm_module_loader.c b/src/cpu/x86/smm/smm_module_loader.c
index ca6f611..856ca78 100644
--- a/src/cpu/x86/smm/smm_module_loader.c
+++ b/src/cpu/x86/smm/smm_module_loader.c
@@ -396,7 +396,7 @@
    /* Does the required amount of memory exceed the SMRAM region size? */
    total_size = total_stack_size + handler_size;
    total_size += fxsave_size + SMM_DEFAULT_SIZE;
-	// account for the BIOS resource list
+	/* Account for the BIOS resource list */
    if (CONFIG(STM))
    	total_size += CONFIG_BIOS_RESOURCE_LIST_SIZE;

Change in coreboot[master]: cpu/x86/smm: Convert C++ style comment

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38854 )

Change subject: cpu/x86/smm: Convert C++ style comment
......................................................................

Patch Set 8:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3
Emulation targets:
EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/728
EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/727
EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/726

Please note: This test is under development and might not be accurate at all!