Attention is currently required from: Julius Werner, Felix Held. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63754 )
Change subject: RFC: Kconfig - show boards supported on 4.11 branch (POC) ......................................................................
Patch Set 2:
(2 comments)
File Makefile:
https://review.coreboot.org/c/coreboot/+/63754/comment/abb67e2a_d0531238 PS2, Line 183: ifeq ($(CONFIG_MAINBOARD_SUPPORTED_ON_BRANCH),y)
nit: I feel like this would better fit in Makefile.inc, with the other Git stuff (e.g. […]
It really needs to go at this spot, otherwise toolchaain.inc will fail the make because there's no architecture declared for any of the stages.
It could go directly into toolchain.inc if you'd prefer.
File src/mainboard/adi/Kconfig:
PS2:
Can we stuff these vendors that have only branch mainboards in some separate directory (e.g. […]
Unfortunately, we can't if we want to keep the list in alphabetical order. The Kconfig source command just reads the Kconfig files from the filesystem in alphabetical order. I agree with you, I don't like creating the directories this way.
What if we added a suffix to the newly created mainboard directories to at least indicate ones that don't contain any actual boards?
So this file would be src/mainboard/adi__/Kconfig.
It's not a great solution, but it's something.
-
Martin L Roth (Code Review)