Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44297 )
Change subject: mb/asrock/h110m: Fix devicetree and unwanted rebase ......................................................................
mb/asrock/h110m: Fix devicetree and unwanted rebase
Unfortunately it came to an unwanted rebase while changing the commit message with gerrit at CB:44026, which breaks building the Asrock H110M on master. Therefore remove Device4Enable from devicetree, since it doesn't exist anymore.
It looks like with changing the commit message at CB:44026, gerrit rebased all previous commits on master. In this case, this is CB:44027. The rebase is not mentioned in the log, but the diff between patchset 1 and patchset 2 (which is new and not made by me) shows that the parent changed.
CB:43919 relocated several devicetree options, including the option Device4Enable, and to me it looks like with the rebase this line just disappeared for gerrit and thus it just removed it from CB:44026.
Change-Id: I848b6442a16f392b71b80bf82c8337bf46d7d771 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/asrock/h110m/devicetree.cb 1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/44297/1
diff --git a/src/mainboard/asrock/h110m/devicetree.cb b/src/mainboard/asrock/h110m/devicetree.cb index 68ef2a4..6de2a63 100644 --- a/src/mainboard/asrock/h110m/devicetree.cb +++ b/src/mainboard/asrock/h110m/devicetree.cb @@ -152,9 +152,7 @@ device pci 02.0 on # Integrated Graphics Device subsystemid 0x1849 0x1912 end - device pci 04.0 on # Thermal Subsystem - register "Device4Enable" = "1" - end + device pci 04.0 on end # Thermal Subsystem device pci 08.0 off end # Gaussian Mixture Model device pci 14.0 on # USB xHCI subsystemid 0x1849 0xa131
Felix Singer has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/44297 )
Change subject: mb/asrock/h110m: Fix devicetree and unwanted rebase ......................................................................
mb/asrock/h110m: Fix devicetree and unwanted rebase
Unfortunately it came to an unwanted rebase while changing the commit message with gerrit at CB:44026, which breaks building the Asrock H110M on master. Therefore remove Device4Enable from devicetree, since it doesn't exist anymore.
It looks like with changing the commit message at CB:44026, gerrit rebased all previous commits on master. In this case, this is CB:44027. The rebase is not mentioned in the log, but the diff between patchset 1 and patchset 2 (which is new and not made by me) shows that the parent changed.
CB:43919 relocated several devicetree options earlier, including the option Device4Enable, and to me it looks like with the rebase this line just disappeared for gerrit and thus gerrit just removed it from CB:44026.
Change-Id: I848b6442a16f392b71b80bf82c8337bf46d7d771 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/asrock/h110m/devicetree.cb 1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/44297/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44297
to look at the new patch set (#3).
Change subject: mb/asrock/h110m: Fix devicetree and unwanted rebase ......................................................................
mb/asrock/h110m: Fix devicetree and unwanted rebase
Unfortunately it came to an unwanted rebase while changing the commit message with gerrit at CB:44026, which breaks building the Asrock H110M on master. Therefore remove Device4Enable from devicetree, since it doesn't exist anymore.
It looks like with changing the commit message at CB:44026, gerrit rebased all previous commits on master. In this case, this is CB:44027. The rebase is not mentioned in the log, but the diff between patchset 1 and patchset 2 (which is new and not made by me) shows that the parent changed.
CB:43919 relocated several devicetree options earlier, including the option Device4Enable, and to me it looks like with the rebase this line just disappeared for gerrit and thus gerrit just removed it from CB:44026.
Change-Id: I848b6442a16f392b71b80bf82c8337bf46d7d771 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/asrock/h110m/devicetree.cb 1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/44297/3
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44297
to look at the new patch set (#4).
Change subject: mb/asrock/h110m: Fix master and unbreak devicetree ......................................................................
mb/asrock/h110m: Fix master and unbreak devicetree
Unfortunately it came to an unwanted rebase while changing the commit message with gerrit at CB:44026, which breaks building the Asrock H110M on master. Therefore remove Device4Enable from devicetree, since it doesn't exist anymore.
It looks like with changing the commit message at CB:44026, gerrit rebased all previous commits on master. In this case, this is CB:44027. The rebase is not mentioned in the log, but the diff between patchset 1 and patchset 2 (which is new and not made by me) shows that the parent changed.
CB:43919 relocated several devicetree options earlier, including the option Device4Enable, and to me it looks like with the rebase this line just disappeared for gerrit and thus gerrit just removed it from CB:44026.
Change-Id: I848b6442a16f392b71b80bf82c8337bf46d7d771 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/asrock/h110m/devicetree.cb 1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/44297/4
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44297 )
Change subject: mb/asrock/h110m: Fix master and unbreak devicetree ......................................................................
Patch Set 4: Code-Review+2
Felix Singer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44297 )
Change subject: mb/asrock/h110m: Fix master and unbreak devicetree ......................................................................
Abandoned
Let's just use CB:43079
-
Felix Singer (Code Review) -
Michael Niewöhner (Code Review)