Nico Huber has uploaded this change for review. ( https://review.coreboot.org/29571
Change subject: drivers/uart/Kconfig: Be smarter about DRIVERS_UART_8250IO ......................................................................
drivers/uart/Kconfig: Be smarter about DRIVERS_UART_8250IO
It defaults to y to avoid having to select it per mainboard. But that makes a mess because it results in linker conflicts unless other UART drivers disable it explicitly.
We try to be smarter about the default value for now. The real solu- tion would be to hardcode it per mainboard. But who knows which boards actually have it?
Change-Id: I7e755fe0e4f6d1c31ef2854603a5510c3cdc4967 Signed-off-by: Nico Huber nico.h@gmx.de --- M src/drivers/uart/Kconfig M src/soc/intel/denverton_ns/Kconfig 2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/29571/1
diff --git a/src/drivers/uart/Kconfig b/src/drivers/uart/Kconfig index 39d20a3..1130aeb 100644 --- a/src/drivers/uart/Kconfig +++ b/src/drivers/uart/Kconfig @@ -4,8 +4,11 @@ default n
config DRIVERS_UART_8250IO + # FIXME: Shouldn't have a prompt, should default to n, and + # should be selected by boards that have it instead. bool "Serial port on SuperIO" depends on ARCH_X86 + default n if DRIVERS_UART_8250MEM || HAVE_UART_SPECIAL default n if NO_UART_ON_SUPERIO default y
diff --git a/src/soc/intel/denverton_ns/Kconfig b/src/soc/intel/denverton_ns/Kconfig index 736d567..59655ce 100644 --- a/src/soc/intel/denverton_ns/Kconfig +++ b/src/soc/intel/denverton_ns/Kconfig @@ -166,7 +166,7 @@ endchoice
config ENABLE_HSUART - depends on (!DRIVERS_UART_8250IO && NON_LEGACY_UART_MODE) + depends on NON_LEGACY_UART_MODE bool "Enable High-speed UART debug port selected by UART_FOR_CONSOLE." default n select CONSOLE_SERIAL