Attention is currently required from: Eric Lai, Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74317 )
Change subject: util/cbfstool: Add "Comp" column for "print -k" ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: So, the reason I didn't do this in CB:41119 is because I was worried that changing the output might break scripts relying on the current behavior. The point of -k is that it can be parsed by a script, after all. My idea was to basically keep `cbfstool print -k` unchanged as the "legacy" machine-parseable output, and make `cbfstool print -k -v` (which was previously unused) the extensible format that allows an arbitrary amount of `<name>:<value>` tokens in each row behind the default column output.
I'm not super against changing the legacy format if we want to do that, but that should probably be discussed on the mailing list first to make sure that everyone has a chance to adjust. (Also, if we do decide to break compatibility we might as well go all the way and change the whole output to something that's more extensible, e.g. using `<key>:<value>` tokens for all fields.)
-
Julius Werner (Code Review)