Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/37162 )
Change subject: WIP: cleanup ......................................................................
WIP: cleanup
Change-Id: I1cd679bc1035834e0ebb868b473e343dafcc35f3 --- M .gitignore M Makefile M makechips.sh 3 files changed, 5 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/em100 refs/changes/62/37162/1
diff --git a/.gitignore b/.gitignore index c89766e..1281d6f 100644 --- a/.gitignore +++ b/.gitignore @@ -4,5 +4,6 @@ /makechips /makedpfw /EM100Pro.msi +/*.dpfw .dependencies *.o diff --git a/Makefile b/Makefile index 5568529..3b24170 100644 --- a/Makefile +++ b/Makefile @@ -70,7 +70,7 @@ clean: rm -f em100 makedpfw rm -f $(OBJECTS) - rm -rf configs firmware + rm -rf configs{,.tar.xz} firmware{,.tar.xz} rm -f .dependencies
distclean: clean diff --git a/makechips.sh b/makechips.sh index 727c18d..00c8304 100755 --- a/makechips.sh +++ b/makechips.sh @@ -69,10 +69,10 @@ $WD/makedpfw -m "$i/2.bin" -M $mcu_version -f "$i/1.bin" -F $fpga_version \ -o $WD/firmware/em100pro_fw_${mcu_version}_${fpga_version}_${voltage}.dpfw done -echo "${VERSION}" > $WD/firmware/VERSION +echo -n "${VERSION}" > $WD/firmware/VERSION
cd $WD -tar cJf configs.tar.xz configs -tar cJf firmware.tar.xz firmware +LANG=C tar cJf configs.tar.xz --sort=name configs +LANG=C tar cJf firmware.tar.xz --sort=name firmware
rm -rf $TEMP
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/em100/+/37162
to look at the new patch set (#2).
Change subject: WIP: cleanup ......................................................................
WIP: cleanup
Change-Id: I1cd679bc1035834e0ebb868b473e343dafcc35f3 --- M .gitignore M Makefile M chips.c M em100.c M makechips.sh 5 files changed, 9 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/em100 refs/changes/62/37162/2
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/em100/+/37162
to look at the new patch set (#3).
Change subject: Add firmware files to .gitignore ......................................................................
Add firmware files to .gitignore
Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org
Change-Id: I1cd679bc1035834e0ebb868b473e343dafcc35f3 --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/em100 refs/changes/62/37162/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37162 )
Change subject: Add firmware files to .gitignore ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/em100/+/37162/3/.gitignore File .gitignore:
https://review.coreboot.org/c/em100/+/37162/3/.gitignore@7 PS3, Line 7: /*.dpfw If I'm not mistaken, this only matches on firmware files inside the root directory. Is that intended?
Ryan O'Leary has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37162 )
Change subject: Add firmware files to .gitignore ......................................................................
Patch Set 3: Code-Review+1
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37162 )
Change subject: Add firmware files to .gitignore ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/em100/+/37162/3/.gitignore File .gitignore:
https://review.coreboot.org/c/em100/+/37162/3/.gitignore@7 PS3, Line 7: /*.dpfw
If I'm not mistaken, this only matches on firmware files inside the root directory. […]
Yeah the stuff downloaded by the scripts lands in firmware/ so this is for when you're experimenting with a few hand crafted or manually downloaded dpfws.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37162 )
Change subject: Add firmware files to .gitignore ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/em100/+/37162/3/.gitignore File .gitignore:
https://review.coreboot.org/c/em100/+/37162/3/.gitignore@7 PS3, Line 7: /*.dpfw
Yeah the stuff downloaded by the scripts lands in firmware/ so this is for when you're experimenting […]
Ack
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37162 )
Change subject: Add firmware files to .gitignore ......................................................................
Patch Set 3: Code-Review+1
Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/em100/+/37162 )
Change subject: Add firmware files to .gitignore ......................................................................
Add firmware files to .gitignore
Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org
Change-Id: I1cd679bc1035834e0ebb868b473e343dafcc35f3 Reviewed-on: https://review.coreboot.org/c/em100/+/37162 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Ryan O'Leary ryanoleary@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved Ryan O'Leary: Looks good to me, but someone else must approve
diff --git a/.gitignore b/.gitignore index c89766e..1281d6f 100644 --- a/.gitignore +++ b/.gitignore @@ -4,5 +4,6 @@ /makechips /makedpfw /EM100Pro.msi +/*.dpfw .dependencies *.o
-
Angel Pons (Code Review) -
Paul Menzel (Code Review)
-
Ryan O'Leary (Code Review)
-
Stefan Reinauer (Code Review)